Hi!
4.15-rcX is broken, but that had other problems so lets not go there.
4.14 is broken.
4.12 is ok.
4.13 is ok.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Sunday, December 24, 2017 12:49:21 PM CET Pavel Machek wrote:
> Hi!
>
> 4.15-rcX is broken, but that had other problems so lets not go there.
>
> 4.14 is broken.
And what exactly does happen?
> 4.12 is ok.
> 4.13 is ok.
Thanks,
Rafael
On Sun 2017-12-24 13:04:31, Rafael J. Wysocki wrote:
> On Sunday, December 24, 2017 12:49:21 PM CET Pavel Machek wrote:
> > Hi!
> >
> > 4.15-rcX is broken, but that had other problems so lets not go there.
> >
> > 4.14 is broken.
>
> And what exactly does happen?
Suspend looks ok. I believe there's some reaction to power button, but
screen stays blank. I'll re-check that.. I'm in the middle of bisect now.
Is there something in 4.14.X I should try?
> > 4.12 is ok.
> > 4.13 is ok.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Sun 2017-12-24 16:22:32, Pavel Machek wrote:
> On Sun 2017-12-24 13:04:31, Rafael J. Wysocki wrote:
> > On Sunday, December 24, 2017 12:49:21 PM CET Pavel Machek wrote:
> > > Hi!
> > >
> > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > >
> > > 4.14 is broken.
> >
> > And what exactly does happen?
>
> Suspend looks ok. I believe there's some reaction to power button, but
> screen stays blank. I'll re-check that.. I'm in the middle of bisect
> now.
Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
bluetooth LEDs go on, but screen is black and no response to anything.
# bad: [eb3b451f8b5a6eb0ebe09ff0f79937977f985a36] Configuration for final v4.14
# good: [9fd3408ca15f4018466e87255ab2644f54de1c1c] "Definitely say Y... so it should be default."
git bisect start 'my-v4.14' 'my-v4.13'
# good: [088eb54dfadd2cdaeb50969fadda4ecfd8d490c2] Date: Wed, 6 Sep 2017 09:03:47 +0300 From: Adrian Hunter <[email protected]> To: Shawn Lin <[email protected]>, Pavel Machek <[email protected]>, [email protected] Cc: kernel list <[email protected]>, Seraphime Kirkovski <[email protected]> Subject: Re: 4.13 on thinkpad x220: oops when writing to SD card
git bisect good 088eb54dfadd2cdaeb50969fadda4ecfd8d490c2
# good: [15d8ffc96464f6571ecf22043c45fad659f11bdd] Merge tag 'mmc-v4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
git bisect good 15d8ffc96464f6571ecf22043c45fad659f11bdd
# good: [e90937e756938f03d37d4cae7c82316a3a425944] Merge tag 'armsoc-devicetree' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good e90937e756938f03d37d4cae7c82316a3a425944
(next one is bad).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > >
> > > > 4.14 is broken.
> > >
> > > And what exactly does happen?
> >
> > Suspend looks ok. I believe there's some reaction to power button, but
> > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > now.
>
> Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> bluetooth LEDs go on, but screen is black and no response to
> > > > anything.
And it seems bad commit is
commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
Author: Greg Kroah-Hartman <[email protected]>
Date: Thu Sep 14 14:23:01 2017 -0700
firmware: delete in-kernel firmware
Unfortuantely, it does not revert cleanly.
lspavel@hobit:~$ lspci
00:00.0 Host bridge: Intel Corporation 82855PM Processor to I/O
Controller (rev 03)
00:01.0 PCI bridge: Intel Corporation 82855PM Processor to AGP
Controller (rev 03)
00:1d.0 USB controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 01)
00:1d.1 USB controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 01)
00:1d.2 USB controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 01)
00:1d.7 USB controller: Intel Corporation 82801DB/DBM (ICH4/ICH4-M)
USB2 EHCI Controller (rev 01)
00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev 81)
00:1f.0 ISA bridge: Intel Corporation 82801DBM (ICH4-M) LPC Interface
Bridge (rev 01)
00:1f.1 IDE interface: Intel Corporation 82801DBM (ICH4-M) IDE
Controller (rev 01)
00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M)
SMBus Controller (rev 01)
00:1f.5 Multimedia audio controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 01)
00:1f.6 Modem: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M)
AC'97 Modem Controller (rev 01)
01:00.0 VGA compatible controller: Advanced Micro Devices,
Inc. [AMD/ATI] RV250/M9 GL [Mobility FireGL 9000/Radeon 9000] (rev 02)
02:00.0 CardBus bridge: Texas Instruments PCI1520 PC card Cardbus
Controller (rev 01)
02:00.1 CardBus bridge: Texas Instruments PCI1520 PC card Cardbus
Controller (rev 01)
02:01.0 Ethernet controller: Intel Corporation 82540EP Gigabit
Ethernet Controller (Mobile) (rev 03)
02:02.0 Ethernet controller: Qualcomm Atheros AR5211 Wireless Network
Adapter [AR5001X 802.11ab] (rev 01)
pavel@hobit:~$
5620a0d1aacd554ebebcff373e31107bb1ef7769 contains:
firmware/radeon/R200_cp.bin.ihex | 130
..maybe that's the reason?
Pavel
# bad: [eb3b451f8b5a6eb0ebe09ff0f79937977f985a36] Configuration for final v4.14
# good: [9fd3408ca15f4018466e87255ab2644f54de1c1c] "Definitely say Y... so it should be default."
git bisect start 'my-v4.14' 'my-v4.13'
# good: [088eb54dfadd2cdaeb50969fadda4ecfd8d490c2] Date: Wed, 6 Sep 2017 09:03:47 +0300 From: Adrian Hunter <[email protected]> To: Shawn Lin <[email protected]>, Pavel Machek <[email protected]>, [email protected] Cc: kernel list <[email protected]>, Seraphime Kirkovski <[email protected]> Subject: Re: 4.13 on thinkpad x220: oops when writing to SD card
git bisect good 088eb54dfadd2cdaeb50969fadda4ecfd8d490c2
# good: [15d8ffc96464f6571ecf22043c45fad659f11bdd] Merge tag 'mmc-v4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
git bisect good 15d8ffc96464f6571ecf22043c45fad659f11bdd
# good: [e90937e756938f03d37d4cae7c82316a3a425944] Merge tag 'armsoc-devicetree' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good e90937e756938f03d37d4cae7c82316a3a425944
# bad: [93b5533ab58d635968ebb0939fe90f3b022601af] Merge tag 'pci-v4.14-fixes-3' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
git bisect bad 93b5533ab58d635968ebb0939fe90f3b022601af
# bad: [9db59599ae502b38b27cff6462273f84acd59927] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
git bisect bad 9db59599ae502b38b27cff6462273f84acd59927
# good: [561a8eb3e1d219f415597c76dae44b530b7f961a] Merge tag 'rtc-4.14' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux
git bisect good 561a8eb3e1d219f415597c76dae44b530b7f961a
# good: [939ae58960bb5ce0c51776aec38877a401c03bcf] Merge git://http://www.linux-watchdog.org/linux-watchdog
git bisect good 939ae58960bb5ce0c51776aec38877a401c03bcf
# good: [e7cdb60fd28b252f1c15a0e50f79a01906124915] Merge branch 'zstd-minimal' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
git bisect good e7cdb60fd28b252f1c15a0e50f79a01906124915
# good: [9e0ce554b039e3df288d83189ecf226c16da04af] Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect good 9e0ce554b039e3df288d83189ecf226c16da04af
# good: [4c0b4bc60f95de4741c89b41174760258343f091] kvm,mips: Fix potential swait_active() races
git bisect good 4c0b4bc60f95de4741c89b41174760258343f091
# good: [30db202e54d251e4887935f7b4538b44911bb091] Merge tag 'for-linus-4.14-ofs2' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux
git bisect good 30db202e54d251e4887935f7b4538b44911bb091
# good: [866a30efdcb63a330b480600d0b501547f9a5a58] Merge tag 'nios2-v4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/lftan/nios2
git bisect good 866a30efdcb63a330b480600d0b501547f9a5a58
# good: [4f350c6dbcb9000e18907515ec8a7b205ac33c69] kvm: nVMX: Handle deferred early VMLAUNCH/VMRESUME failure properly
git bisect good 4f350c6dbcb9000e18907515ec8a7b205ac33c69
# bad: [b38923a068c10fc36ca8f596d650d095ce390b85] Merge tag 'firmware_removal-4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
git bisect bad b38923a068c10fc36ca8f596d650d095ce390b85
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > >
> > > > > 4.14 is broken.
> > > >
> > > > And what exactly does happen?
> > >
> > > Suspend looks ok. I believe there's some reaction to power button, but
> > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > now.
> >
> > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > bluetooth LEDs go on, but screen is black and no response to
> > > > > anything.
>
> And it seems bad commit is
>
> commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> Author: Greg Kroah-Hartman <[email protected]>
> Date: Thu Sep 14 14:23:01 2017 -0700
>
> firmware: delete in-kernel firmware
>
> Unfortuantely, it does not revert cleanly.
I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
top of it, partialy reverting it. Seems like 5620 was causing problems
for other people before.
And then there's huge mega-patch called "license cleanup" on top of
that, which changes 11100 files (!) and makes work harder still.
Can we go for full revert?
Changelog
""" The last firmware change for the in-kernel firmware source code
was back
in 2013. Everyone has been relying on the out-of-tree
linux-firmware
package for a long long time."""
does not really explain what is going on there, and I'd certainly not
expect silent breakage of suspend/resume. Clearly 5620a0 patch did not
get nearly enough testing.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> > And it seems bad commit is
> >
> > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > Author: Greg Kroah-Hartman <[email protected]>
> > Date: Thu Sep 14 14:23:01 2017 -0700
> >
> > firmware: delete in-kernel firmware
> >
> > Unfortuantely, it does not revert cleanly.
>
> I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> top of it, partialy reverting it. Seems like 5620 was causing problems
> for other people before.
>
> And then there's huge mega-patch called "license cleanup" on top of
> that, which changes 11100 files (!) and makes work harder still.
>
> Can we go for full revert?
And revert indeed fixes suspend on T40p on v4.15-rc5.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On 2017.12.24 at 23:37 +0100, Pavel Machek wrote:
> Hi!
>
> > > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > > >
> > > > > > 4.14 is broken.
> > > > >
> > > > > And what exactly does happen?
> > > >
> > > > Suspend looks ok. I believe there's some reaction to power button, but
> > > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > > now.
> > >
> > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > anything.
> >
> > And it seems bad commit is
> >
> > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > Author: Greg Kroah-Hartman <[email protected]>
> > Date: Thu Sep 14 14:23:01 2017 -0700
> >
> > firmware: delete in-kernel firmware
> >
> > Unfortuantely, it does not revert cleanly.
>
> I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> top of it, partialy reverting it. Seems like 5620 was causing problems
> for other people before.
>
> And then there's huge mega-patch called "license cleanup" on top of
> that, which changes 11100 files (!) and makes work harder still.
>
> Can we go for full revert?
No, it does not make any sense.
Could you please post your config?
--
Markus
On Mon 2017-12-25 09:47:48, Markus Trippelsdorf wrote:
> On 2017.12.24 at 23:37 +0100, Pavel Machek wrote:
> > Hi!
> >
> > > > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > > > >
> > > > > > > 4.14 is broken.
> > > > > >
> > > > > > And what exactly does happen?
> > > > >
> > > > > Suspend looks ok. I believe there's some reaction to power button, but
> > > > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > > > now.
> > > >
> > > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > > anything.
> > >
> > > And it seems bad commit is
> > >
> > > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > > Author: Greg Kroah-Hartman <[email protected]>
> > > Date: Thu Sep 14 14:23:01 2017 -0700
> > >
> > > firmware: delete in-kernel firmware
> > >
> > > Unfortuantely, it does not revert cleanly.
> >
> > I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> > top of it, partialy reverting it. Seems like 5620 was causing problems
> > for other people before.
> >
> > And then there's huge mega-patch called "license cleanup" on top of
> > that, which changes 11100 files (!) and makes work harder still.
> >
> > Can we go for full revert?
>
> No, it does not make any sense.
> Could you please post your config?
Well.. neither makes the original commit message any sense :-(.
Config is attached.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On 2017.12.25 at 10:54 +0100, Pavel Machek wrote:
> On Mon 2017-12-25 09:47:48, Markus Trippelsdorf wrote:
> > On 2017.12.24 at 23:37 +0100, Pavel Machek wrote:
> > > Hi!
> > >
> > > > > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > > > > >
> > > > > > > > 4.14 is broken.
> > > > > > >
> > > > > > > And what exactly does happen?
> > > > > >
> > > > > > Suspend looks ok. I believe there's some reaction to power button, but
> > > > > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > > > > now.
> > > > >
> > > > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > > > anything.
> > > >
> > > > And it seems bad commit is
> > > >
> > > > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > > > Author: Greg Kroah-Hartman <[email protected]>
> > > > Date: Thu Sep 14 14:23:01 2017 -0700
> > > >
> > > > firmware: delete in-kernel firmware
> > > >
> > > > Unfortuantely, it does not revert cleanly.
> > >
> > > I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> > > top of it, partialy reverting it. Seems like 5620 was causing problems
> > > for other people before.
> > >
> > > And then there's huge mega-patch called "license cleanup" on top of
> > > that, which changes 11100 files (!) and makes work harder still.
> > >
> > > Can we go for full revert?
> >
> > No, it does not make any sense.
> > Could you please post your config?
>
> Well.. neither makes the original commit message any sense :-(.
>
> CONFIG_PREVENT_FIRMWARE_BUILD=y
> CONFIG_FW_LOADER=y
> CONFIG_FIRMWARE_IN_KERNEL=y
> CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin iwlwifi-1000-5.ucode"
> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
Looks like a pilot error to me. You have a R200 card, but you load R700
firmware. Try:
CONFIG_EXTRA_FIRMWARE="radeon/R200_cp.bin iwlwifi-1000-5.ucode"
instead.
--
Markus
Hi!
> > > > > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > > > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > > > > anything.
> > > > >
> > > > > And it seems bad commit is
> > > > >
> > > > > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > > > > Author: Greg Kroah-Hartman <[email protected]>
> > > > > Date: Thu Sep 14 14:23:01 2017 -0700
> > > > >
> > > > > firmware: delete in-kernel firmware
> > > > >
> > > > > Unfortuantely, it does not revert cleanly.
> > > >
> > > > I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> > > > top of it, partialy reverting it. Seems like 5620 was causing problems
> > > > for other people before.
> > > >
> > > > And then there's huge mega-patch called "license cleanup" on top of
> > > > that, which changes 11100 files (!) and makes work harder still.
> > > >
> > > > Can we go for full revert?
> > >
> > > No, it does not make any sense.
> > > Could you please post your config?
> >
> > Well.. neither makes the original commit message any sense :-(.
> >
> > CONFIG_PREVENT_FIRMWARE_BUILD=y
> > CONFIG_FW_LOADER=y
> > CONFIG_FIRMWARE_IN_KERNEL=y
> > CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin iwlwifi-1000-5.ucode"
> > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
>
> Looks like a pilot error to me. You have a R200 card, but you load R700
> firmware. Try:
> CONFIG_EXTRA_FIRMWARE="radeon/R200_cp.bin iwlwifi-1000-5.ucode"
> instead.
So... With modified extra firmware line, it works for me. Good.
But... it worked before. So that's still a regression and hard to
debug one, and probably going to happen to more users than just
me. Yeah, pilot landed on wrong runway, but this should not lead to
his engines exploding and black box being erased.
What is going on there? Why did it work before?
Is there way we could warn during boot (or suspend) "hey, you need
this firmware for resume"?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html