2017-12-26 04:22:00

by Jiaxun Yang

[permalink] [raw]
Subject: [PATCH] MIPS: Loongson64: Drop 32-bit support for Loongson 2E/2F devices

Make loongson64 a pure 64-bit mach.

Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/loongson64/Kconfig | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
index 0d249fc3cfe9..a7d9a9241ac4 100644
--- a/arch/mips/loongson64/Kconfig
+++ b/arch/mips/loongson64/Kconfig
@@ -17,7 +17,6 @@ config LEMOTE_FULOONG2E
select I8259
select ISA
select IRQ_MIPS_CPU
- select SYS_SUPPORTS_32BIT_KERNEL
select SYS_SUPPORTS_64BIT_KERNEL
select SYS_SUPPORTS_LITTLE_ENDIAN
select SYS_SUPPORTS_HIGHMEM
@@ -49,7 +48,6 @@ config LEMOTE_MACH2F
select ISA
select SYS_HAS_CPU_LOONGSON2F
select SYS_HAS_EARLY_PRINTK
- select SYS_SUPPORTS_32BIT_KERNEL
select SYS_SUPPORTS_64BIT_KERNEL
select SYS_SUPPORTS_HIGHMEM
select SYS_SUPPORTS_LITTLE_ENDIAN
--
2.15.1


2018-01-02 08:48:26

by James Hogan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Loongson64: Drop 32-bit support for Loongson 2E/2F devices

On Tue, Dec 26, 2017 at 12:21:38PM +0800, Jiaxun Yang wrote:
> Make loongson64 a pure 64-bit mach.

Please expand to provide some rationale behind the change. Was 32-bit
support broken at runtime, or broken at build time, or are we simply no
longer interested in supporting it?

Cheers
James

>
> Signed-off-by: Jiaxun Yang <[email protected]>
> ---
> arch/mips/loongson64/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
> index 0d249fc3cfe9..a7d9a9241ac4 100644
> --- a/arch/mips/loongson64/Kconfig
> +++ b/arch/mips/loongson64/Kconfig
> @@ -17,7 +17,6 @@ config LEMOTE_FULOONG2E
> select I8259
> select ISA
> select IRQ_MIPS_CPU
> - select SYS_SUPPORTS_32BIT_KERNEL
> select SYS_SUPPORTS_64BIT_KERNEL
> select SYS_SUPPORTS_LITTLE_ENDIAN
> select SYS_SUPPORTS_HIGHMEM
> @@ -49,7 +48,6 @@ config LEMOTE_MACH2F
> select ISA
> select SYS_HAS_CPU_LOONGSON2F
> select SYS_HAS_EARLY_PRINTK
> - select SYS_SUPPORTS_32BIT_KERNEL
> select SYS_SUPPORTS_64BIT_KERNEL
> select SYS_SUPPORTS_HIGHMEM
> select SYS_SUPPORTS_LITTLE_ENDIAN
> --
> 2.15.1
>

Attachments:
(No filename) (1.12 kB)
 signature.asc (833.00 B)
Digital signature Download all attachments

2018-01-02 13:31:14

by Jiaxun Yang

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Loongson64: Drop 32-bit support for Loongson 2E/2F devices

On 2018-01-02 Tue 08:48 +0000，James Hogan Wrote：
> On Tue, Dec 26, 2017 at 12:21:38PM +0800, Jiaxun Yang wrote:
> > Make loongson64 a pure 64-bit mach.
>
> Please expand to provide some rationale behind the change. Was 32-bit
> support broken at runtime, or broken at build time, or are we simply
> no

The 32-bit support was broken at runtime, it doesn't boot anymore,
witch is hard to debug because even early printk isn't working, also
there are some build warnings. Some newer bootloader may not support
32-bit ELF. So we decide to drop 32-bit support.

Jiaxun

> longer interested in supporting it?
>
> Cheers
> James
>
> >
> > Signed-off-by: Jiaxun Yang <[email protected]>
> > ---
> > arch/mips/loongson64/Kconfig | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/mips/loongson64/Kconfig
> > b/arch/mips/loongson64/Kconfig
> > index 0d249fc3cfe9..a7d9a9241ac4 100644
> > --- a/arch/mips/loongson64/Kconfig
> > +++ b/arch/mips/loongson64/Kconfig
> > @@ -17,7 +17,6 @@ config LEMOTE_FULOONG2E
> > select I8259
> > select ISA
> > select IRQ_MIPS_CPU
> > - select SYS_SUPPORTS_32BIT_KERNEL
> > select SYS_SUPPORTS_64BIT_KERNEL
> > select SYS_SUPPORTS_LITTLE_ENDIAN
> > select SYS_SUPPORTS_HIGHMEM
> > @@ -49,7 +48,6 @@ config LEMOTE_MACH2F
> > select ISA
> > select SYS_HAS_CPU_LOONGSON2F
> > select SYS_HAS_EARLY_PRINTK
> > - select SYS_SUPPORTS_32BIT_KERNEL
> > select SYS_SUPPORTS_64BIT_KERNEL
> > select SYS_SUPPORTS_HIGHMEM
> > select SYS_SUPPORTS_LITTLE_ENDIAN
> > --
> > 2.15.1
> >

Attachments:
signature.asc (833.00 B)
This is a digitally signed message part

2018-01-02 13:40:14

by James Hogan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Loongson64: Drop 32-bit support for Loongson 2E/2F devices

On Tue, Jan 02, 2018 at 09:29:46PM +0800, Jiaxun Yang wrote:
> On 2018-01-02 Tue 08:48 +0000，James Hogan Wrote：
> > On Tue, Dec 26, 2017 at 12:21:38PM +0800, Jiaxun Yang wrote:
> > > Make loongson64 a pure 64-bit mach.
> >
> > Please expand to provide some rationale behind the change. Was 32-bit
> > support broken at runtime, or broken at build time, or are we simply
> > no
>
> The 32-bit support was broken at runtime, it doesn't boot anymore,
> witch is hard to debug because even early printk isn't working, also
> there are some build warnings. Some newer bootloader may not support
> 32-bit ELF. So we decide to drop 32-bit support.

Okay, please put that in the commit message so that somebody digging
through the history later (perhaps summarising what is new in the next
release) can understand the *why* as well as the what.

Cheers
James

Attachments:
(No filename) (857.00 B)
 signature.asc (833.00 B)
Digital signature Download all attachments