2018-01-02 14:02:11

by Gustavo A. R. Silva

Subject: [PATCH] USB: usbip: remove useless call in usbip_recv

Calling msg_data_left(&msg) is only useful for its return value,
which in this particular case is ignored.

Fix this by removing such call.

Addresses-Coverity-ID: 1427080
Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/usb/usbip/usbip_common.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
index 7b219d9..b5af6fc 100644
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -325,7 +325,6 @@ int usbip_recv(struct socket *sock, void *buf, int size)
usbip_dbg_xmit("enter\n");

do {
- msg_data_left(&msg);
sock->sk->sk_allocation = GFP_NOIO;

result = sock_recvmsg(sock, &msg, MSG_WAITALL);
--
2.7.4

2018-01-02 23:36:45

by Shuah Khan

Subject: Re: [PATCH] USB: usbip: remove useless call in usbip_recv

On 01/02/2018 07:02 AM, Gustavo A. R. Silva wrote:
> Calling msg_data_left(&msg) is only useful for its return value,
> which in this particular case is ignored.
>
> Fix this by removing such call.
>
> Addresses-Coverity-ID: 1427080
> Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/usb/usbip/usbip_common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index 7b219d9..b5af6fc 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -325,7 +325,6 @@ int usbip_recv(struct socket *sock, void *buf, int size)
> usbip_dbg_xmit("enter\n");
>
> do {
> - msg_data_left(&msg);
> sock->sk->sk_allocation = GFP_NOIO;
>
> result = sock_recvmsg(sock, &msg, MSG_WAITALL);
>

Thanks for the patch. Looks good to me.

Acked-by: Shuah Khan <[email protected]>

Greg, please pick this patch up.

thanks,
-- Shuah