2017-12-26 09:30:09

by Aishwarya Pant

[permalink] [raw]
Subject: misc: bh1770glc: move sysfs interace to Documentation/ABI

Hi

In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
interface which could be moved to Documentation/ABI.

Would such a change be useful?

The ABI documentation format looks like the following:

What: (the full sysfs path of the attribute)
Date: (date of creation)
KernelVersion: (kernel version it first showed up in)
Contact: (primary contact)
Description: (long description on usage)

I am doing this in an exercise to move sysfs ABI interfaces (which are
documented) to their right place i.e. in Documentation/ABI along with the rest.

Aishwarya


2018-01-02 13:06:39

by Pavel Machek

[permalink] [raw]
Subject: Re: misc: bh1770glc: move sysfs interace to Documentation/ABI

Hi!

> In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> interface which could be moved to Documentation/ABI.
>
> Would such a change be useful?

Not at the moment.

> The ABI documentation format looks like the following:
>
> What: (the full sysfs path of the attribute)
> Date: (date of creation)
> KernelVersion: (kernel version it first showed up in)
> Contact: (primary contact)
> Description: (long description on usage)
>
> I am doing this in an exercise to move sysfs ABI interfaces (which are
> documented) to their right place i.e. in Documentation/ABI along with the rest.

The interface should probably be changed to iio one, to be consistent
with other sensors such as Apds990x.

If you have the hardware, help would be welcome.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (990.00 B)
signature.asc (181.00 B)
Digital signature
Download all attachments

2018-01-02 17:25:30

by Aishwarya Pant

[permalink] [raw]
Subject: Re: misc: bh1770glc: move sysfs interace to Documentation/ABI

On Tue, Jan 02, 2018 at 02:06:36PM +0100, Pavel Machek wrote:
> Hi!
>
> > In Documentation/misc-devices/bh1770glc.txt, there is a description of the sysfs
> > interface which could be moved to Documentation/ABI.
> >
> > Would such a change be useful?
>
> Not at the moment.
>
> > The ABI documentation format looks like the following:
> >
> > What: (the full sysfs path of the attribute)
> > Date: (date of creation)
> > KernelVersion: (kernel version it first showed up in)
> > Contact: (primary contact)
> > Description: (long description on usage)
> >
> > I am doing this in an exercise to move sysfs ABI interfaces (which are
> > documented) to their right place i.e. in Documentation/ABI along with the rest.
>
> The interface should probably be changed to iio one, to be consistent
> with other sensors such as Apds990x.
>
> If you have the hardware, help would be welcome.

Yes, makes sense for this driver to be with the iio light sensors. I don't have
the hardware for it. So, I won't move the sysfs interface to ABI.

Aishwarya

>
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html