2017-12-24 10:36:51

by Jia-Ju Bai

[permalink] [raw]
Subject: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready

i40iw_wait_pe_ready is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep,
to reduce busy wait.

Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index e824296..8098bc1 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -1285,7 +1285,7 @@ static void i40iw_wait_pe_ready(struct i40iw_hw *hw)
__LINE__, statuscpu2);
if ((statuscpu0 == 0x80) && (statuscpu1 == 0x80) && (statuscpu2 == 0x80))
break; /* SUCCESS */
- mdelay(1000);
+ msleep(1000);
retrycount++;
} while (retrycount < 14);
i40iw_wr32(hw, 0xb4040, 0x4C104C5);
--
1.7.9.5


2017-12-24 11:57:36

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready

On Sun, Dec 24, 2017 at 06:39:40PM +0800, Jia-Ju Bai wrote:
> i40iw_wait_pe_ready is not called in an interrupt handler
> nor holding a spinlock.
> The function mdelay in it can be replaced with msleep,
> to reduce busy wait.
>
> Signed-off-by: Jia-Ju Bai <[email protected]>
> ---
> drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

Attachments:
(No filename) (452.00 B)
 signature.asc (833.00 B)
 Download all attachments

2018-01-05 17:44:45

by Shiraz Saleem

[permalink] [raw]
Subject: Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready

On Sun, Dec 24, 2017 at 03:39:40AM -0700, Jia-Ju Bai wrote:
> i40iw_wait_pe_ready is not called in an interrupt handler
> nor holding a spinlock.
> The function mdelay in it can be replaced with msleep,
> to reduce busy wait.
>
> Signed-off-by: Jia-Ju Bai <[email protected]>
> ---
> drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks!
Acked-by: Shiraz Saleem <[email protected]>



2018-01-05 18:47:15

by Doug Ledford

[permalink] [raw]
Subject: Re: [PATCH] i40iw: Replace mdelay with msleep in i40iw_wait_pe_ready

On Fri, 2018-01-05 at 11:44 -0600, Shiraz Saleem wrote:
> On Sun, Dec 24, 2017 at 03:39:40AM -0700, Jia-Ju Bai wrote:
> > i40iw_wait_pe_ready is not called in an interrupt handler
> > nor holding a spinlock.
> > The function mdelay in it can be replaced with msleep,
> > to reduce busy wait.
> >
> > Signed-off-by: Jia-Ju Bai <[email protected]>
> > ---
> > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Thanks!
> Acked-by: Shiraz Saleem <[email protected]>
>
>

Thanks, applied.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Attachments:
signature.asc (833.00 B)
This is a digitally signed message part