2018-01-08 12:35:59

by Xiongfeng Wang

Subject: [PATCH] media: media-device: use strlcpy() instead of strncpy()

From: Xiongfeng Wang <[email protected]>

gcc-8 reports

drivers/media/media-device.c: In function 'media_device_get_topology':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the dest string is nul-terminated.

Signed-off-by: Xiongfeng Wang <[email protected]>
---
drivers/media/media-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index e79f72b..f442444 100644
--- a/drivers/media/media-device.c
+++ b/drivers/media/media-device.c
@@ -255,7 +255,7 @@ static long media_device_get_topology(struct media_device *mdev,
memset(&kentity, 0, sizeof(kentity));
kentity.id = entity->graph_obj.id;
kentity.function = entity->function;
- strncpy(kentity.name, entity->name,
+ strlcpy(kentity.name, entity->name,
sizeof(kentity.name));

if (copy_to_user(uentity, &kentity, sizeof(kentity)))
--
1.8.3.1

2018-01-08 15:10:17

by Sakari Ailus

Subject: Re: [PATCH] media: media-device: use strlcpy() instead of strncpy()

On Mon, Jan 08, 2018 at 08:40:59PM +0800, Xiongfeng Wang wrote:
> From: Xiongfeng Wang <[email protected]>
>
> gcc-8 reports
>
> drivers/media/media-device.c: In function 'media_device_get_topology':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 64 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is nul-terminated.
>
> Signed-off-by: Xiongfeng Wang <[email protected]>

Acked-by: Sakari Ailus <[email protected]>

--
Sakari Ailus
e-mail: [email protected]