Hi,
Removing the last patch from the original series after Dan's comment.
Tomorrow, I will send a new patch that removes the commented out code. This will
replace that last patch.
Thanks for the review,
Luis
Luis de Bethencourt (2):
staging: rtl8723bs: Fix trailing semicolon
staging: rtl8723bs: Fix trailing semicolon
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.15.1
The trailing semicolon is an empty statement that does nothing.
Removing it since it has no purpose.
Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index 21ec890fd60c..e34d133075c0 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -153,7 +153,7 @@ static u32 phy_RFSerialRead_8723B(
NewOffset = Offset;
if (eRFPath == RF_PATH_A) {
- tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord);;
+ tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord);
tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIReadEdge; /* T65 RF */
PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2&(~bLSSIReadEdge));
} else {
--
2.15.1
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index c16e147d8adc..a99a863be656 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -1052,7 +1052,7 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
/* Check failed */
regEAC = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord);
- regEA4 = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord);;
+ regEA4 = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord);
ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("0xeac = 0x%x\n", regEAC));
ODM_RT_TRACE(pDM_Odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("0xea4 = 0x%x, 0xeac = 0x%x\n", regEA4, regEAC));
--
2.15.1
On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
> Hi,
>
> Removing the last patch from the original series after Dan's comment.
>
> Tomorrow, I will send a new patch that removes the commented out code. This will
> replace that last patch.
>
> Thanks for the review,
> Luis
>
>
> Luis de Bethencourt (2):
> staging: rtl8723bs: Fix trailing semicolon
> staging: rtl8723bs: Fix trailing semicolon
>
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
A little bit too late but I just realized that instead of LKML (which is down),
I can link to the archives of the driverdev mailing list instead.
Here is Dan's email which I reference above:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115392.html
Thanks,
Luis
On Wed, 2018-01-10 at 17:01 +0000, Luis de Bethencourt wrote:
> On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
> > Hi,
> >
> > Removing the last patch from the original series after Dan's comment.
> >
> > Tomorrow, I will send a new patch that removes the commented out code. This will
> > replace that last patch.
> >
> > Thanks for the review,
> > Luis
> >
> >
> > Luis de Bethencourt (2):
> > staging: rtl8723bs: Fix trailing semicolon
> > staging: rtl8723bs: Fix trailing semicolon
> >
> > drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
> > drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> A little bit too late but I just realized that instead of LKML (which is down),
> I can link to the archives of the driverdev mailing list instead.
>
> Here is Dan's email which I reference above:
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115392.html
>
> Thanks,
> Luis
If you really want to remove these, perhaps do it treewide.
$ git grep -P -n ";\s*;\s*$" -- "*.[ch]"|grep -vw for|grep -vP ":\s+;\s*;\s*$"
arch/arc/kernel/setup.c:376: char *opt_nm = NULL;;
arch/arc/kernel/unwind.c:369: panic("Attention !!! Dwarf FDE parsing errors\n");;
arch/arm/include/asm/kvm_emulate.h:134: return cpsr_mode > USR_MODE;;
arch/arm/kernel/time.c:86:static clock_access_fn __read_boot_clock = dummy_clock_access;;
arch/arm64/kernel/ptrace.c:1422: int err, idx = compat_ptrace_hbp_num_to_idx(num);;
arch/mips/include/asm/checksum.h:113: u32 sum = (__force u32)csum;;
arch/powerpc/kvm/book3s_xive.c:160: return -ENOMEM;;
arch/powerpc/platforms/powernv/pci-ioda.c:1843: return -ENODEV;;
arch/x86/boot/compressed/eboot.c:442: u32 *handles = (u32 *)uga_handle;;
arch/x86/boot/compressed/eboot.c:487: u64 *handles = (u64 *)uga_handle;;
block/sed-opal.c:493: return -EOPNOTSUPP;;
drivers/clocksource/mips-gic-timer.c:208: return -EINVAL;;
drivers/clocksource/mips-gic-timer.c:213: return -EINVAL;;
drivers/clocksource/timer-sun5i.c:337: return PTR_ERR(timer_base);;
drivers/dax/device.c:136: return NULL;;
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:721: union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};;
drivers/gpu/drm/amd/powerplay/amd_powerplay.c:165: return -EINVAL;;
drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:683: aspace = NULL;;
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:645: block = (size >> page[i].shift) << page[i].shift;;
drivers/gpu/drm/scheduler/gpu_scheduler.c:464: int i;;
drivers/hwmon/lm75.c:103: break;;
drivers/iommu/intel-svm.c:196: unsigned long mask = __rounddown_pow_of_two(address ^ last);;
drivers/md/dm-thin.c:1725: struct dm_thin_endio_hook *h = dm_per_bio_data(bio, sizeof(struct dm_thin_endio_hook));;
drivers/md/raid1.c:1111: r1_bio->behind_master_bio = behind_bio;;
drivers/net/can/rx-offload.c:259: return can_rx_offload_init_queue(dev, offload, weight);;
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:488: mlx5e_close_channels(&epriv->channels);;
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h:1175: u8 dummy4_1:1;;
drivers/pci/pci-driver.c:971: return pm_generic_freeze_late(dev);;
drivers/powercap/intel_rapl.c:1212: int nr_pl, ret;;
drivers/soc/imx/gpc.c:351: return PTR_ERR(domain->supply);;
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1055: regEA4 = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord);;
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:156: tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord);;
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:970: ret = -EINVAL;;
drivers/target/target_core_user.c:1409: return ret;;
include/net/vxlan.h:304: return features;;
net/netfilter/nft_dynset.c:167: err = nft_validate_register_load(priv->sreg_key, set->klen);;
samples/bpf/xdp_monitor_kern.c:107: u64 *cnt;;
scripts/mod/modpost.c:1688: const char *tosec = sec_name(elf, get_secindex(elf, sym));;
sound/core/pcm_native.c:3449: struct snd_pcm_runtime *runtime = substream->runtime;;
sound/soc/codecs/cs42l73.c:1358: return ret;;
tools/perf/util/evlist.c:1763: goto state_err;;
tools/testing/selftests/nsfs/pidns.c:73: return pr_err("Don't get EPERM");;
On 01/11/2018 01:19 AM, Joe Perches wrote:
> On Wed, 2018-01-10 at 17:01 +0000, Luis de Bethencourt wrote:
>> On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
>>> Hi,
>>>
>>> Removing the last patch from the original series after Dan's comment.
>>>
>>> Tomorrow, I will send a new patch that removes the commented out code. This will
>>> replace that last patch.
>>>
>>> Thanks for the review,
>>> Luis
>>>
>>>
>>> Luis de Bethencourt (2):
>>> staging: rtl8723bs: Fix trailing semicolon
>>> staging: rtl8723bs: Fix trailing semicolon
>>>
>>> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
>>> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>> A little bit too late but I just realized that instead of LKML (which is down),
>> I can link to the archives of the driverdev mailing list instead.
>>
>> Here is Dan's email which I reference above:
>> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115392.html
>>
>> Thanks,
>> Luis
>
> If you really want to remove these, perhaps do it treewide.
>
> $ git grep -P -n ";\s*;\s*$" -- "*.[ch]"|grep -vw for|grep -vP ":\s+;\s*;\s*$"
> arch/arc/kernel/setup.c:376: char *opt_nm = NULL;;
> arch/arc/kernel/unwind.c:369: panic("Attention !!! Dwarf FDE parsing errors\n");;
> arch/arm/include/asm/kvm_emulate.h:134: return cpsr_mode > USR_MODE;;
> arch/arm/kernel/time.c:86:static clock_access_fn __read_boot_clock = dummy_clock_access;;
> arch/arm64/kernel/ptrace.c:1422: int err, idx = compat_ptrace_hbp_num_to_idx(num);;
> arch/mips/include/asm/checksum.h:113: u32 sum = (__force u32)csum;;
> arch/powerpc/kvm/book3s_xive.c:160: return -ENOMEM;;
> arch/powerpc/platforms/powernv/pci-ioda.c:1843: return -ENODEV;;
> arch/x86/boot/compressed/eboot.c:442: u32 *handles = (u32 *)uga_handle;;
> arch/x86/boot/compressed/eboot.c:487: u64 *handles = (u64 *)uga_handle;;
> block/sed-opal.c:493: return -EOPNOTSUPP;;
> drivers/clocksource/mips-gic-timer.c:208: return -EINVAL;;
> drivers/clocksource/mips-gic-timer.c:213: return -EINVAL;;
> drivers/clocksource/timer-sun5i.c:337: return PTR_ERR(timer_base);;
> drivers/dax/device.c:136: return NULL;;
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:721: union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};;
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c:165: return -EINVAL;;
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:683: aspace = NULL;;
> drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:645: block = (size >> page[i].shift) << page[i].shift;;
> drivers/gpu/drm/scheduler/gpu_scheduler.c:464: int i;;
> drivers/hwmon/lm75.c:103: break;;
> drivers/iommu/intel-svm.c:196: unsigned long mask = __rounddown_pow_of_two(address ^ last);;
> drivers/md/dm-thin.c:1725: struct dm_thin_endio_hook *h = dm_per_bio_data(bio, sizeof(struct dm_thin_endio_hook));;
> drivers/md/raid1.c:1111: r1_bio->behind_master_bio = behind_bio;;
> drivers/net/can/rx-offload.c:259: return can_rx_offload_init_queue(dev, offload, weight);;
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:488: mlx5e_close_channels(&epriv->channels);;
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h:1175: u8 dummy4_1:1;;
> drivers/pci/pci-driver.c:971: return pm_generic_freeze_late(dev);;
> drivers/powercap/intel_rapl.c:1212: int nr_pl, ret;;
> drivers/soc/imx/gpc.c:351: return PTR_ERR(domain->supply);;
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1055: regEA4 = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord);;
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c:156: tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord);;
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:970: ret = -EINVAL;;
> drivers/target/target_core_user.c:1409: return ret;;
> include/net/vxlan.h:304: return features;;
> net/netfilter/nft_dynset.c:167: err = nft_validate_register_load(priv->sreg_key, set->klen);;
> samples/bpf/xdp_monitor_kern.c:107: u64 *cnt;;
> scripts/mod/modpost.c:1688: const char *tosec = sec_name(elf, get_secindex(elf, sym));;
> sound/core/pcm_native.c:3449: struct snd_pcm_runtime *runtime = substream->runtime;;
> sound/soc/codecs/cs42l73.c:1358: return ret;;
> tools/perf/util/evlist.c:1763: goto state_err;;
> tools/testing/selftests/nsfs/pidns.c:73: return pr_err("Don't get EPERM");;
>
Hi Joe,
I was following the good-old premise of reading/fixing the code for hardware
you have.
Since you think there is value on fixing the trailing semicolons treewide. I
will slowly do that over the next few days.
Thanks for the feedback,
Luis