2018-01-11 03:03:43

by Yixun Lan

[permalink] [raw]
Subject: [PATCH] ARM64: dts: meson-axg: add RMII pins for ethernet controller

Comparing to RGMII interface, the RMII interface require few pins.
So it's worth describing them here.

Signed-off-by: Yixun Lan <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index a80632641b39..ab4a0e8bc446 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -251,6 +251,36 @@
gpio-ranges = <&pinctrl_periphs 0 0 86>;
};

+ eth_rmii_x_pins: eth-x-rmii {
+ mux {
+ groups = "eth_mdio_x",
+ "eth_mdc_x",
+ "eth_rgmii_rx_clk_x",
+ "eth_rx_dv_x",
+ "eth_rxd0_x",
+ "eth_rxd1_x",
+ "eth_txen_x",
+ "eth_txd0_x",
+ "eth_txd1_x";
+ function = "eth";
+ };
+ };
+
+ eth_rmii_y_pins: eth-y-rmii {
+ mux {
+ groups = "eth_mdio_y",
+ "eth_mdc_y",
+ "eth_rgmii_rx_clk_y",
+ "eth_rx_dv_y",
+ "eth_rxd0_y",
+ "eth_rxd1_y",
+ "eth_txen_y",
+ "eth_txd0_y",
+ "eth_txd1_y";
+ function = "eth";
+ };
+ };
+
eth_rgmii_x_pins: eth-x-rgmii {
mux {
groups = "eth_mdio_x",
--
2.15.1


2018-01-11 08:37:50

by Jerome Brunet

[permalink] [raw]
Subject: Re: [PATCH] ARM64: dts: meson-axg: add RMII pins for ethernet controller

On Thu, 2018-01-11 at 11:04 +0800, Yixun Lan wrote:
> Comparing to RGMII interface, the RMII interface require few pins.
> So it's worth describing them here.
>
> Signed-off-by: Yixun Lan <[email protected]>

The only axg platform we have upstream is the s400 and is using rgmii.
May I ask how this was tested ?

2018-01-11 09:11:12

by Yixun Lan

[permalink] [raw]
Subject: Re: [PATCH] ARM64: dts: meson-axg: add RMII pins for ethernet controller

Hi Jerome:

On 01/11/18 16:37, Jerome Brunet wrote:
> On Thu, 2018-01-11 at 11:04 +0800, Yixun Lan wrote:
>> Comparing to RGMII interface, the RMII interface require few pins.
>> So it's worth describing them here.
>>
>> Signed-off-by: Yixun Lan <[email protected]>
>
> The only axg platform we have upstream is the s400 and is using rgmii.
> May I ask how this was tested ?
>
It's true that S400 using RGMII interface.

but, we have customer using RTL8201FR-VB/VD which is a RMII PHY,

This is actually tested with the 'eth_rmii_x_pins' group.

Yixun

2018-01-11 09:33:33

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] ARM64: dts: meson-axg: add RMII pins for ethernet controller

On 11/01/2018 10:11, Yixun Lan wrote:
> Hi Jerome:
>
> On 01/11/18 16:37, Jerome Brunet wrote:
>> On Thu, 2018-01-11 at 11:04 +0800, Yixun Lan wrote:
>>> Comparing to RGMII interface, the RMII interface require few pins.
>>> So it's worth describing them here.
>>>
>>> Signed-off-by: Yixun Lan <[email protected]>
>>
>> The only axg platform we have upstream is the s400 and is using rgmii.
>> May I ask how this was tested ?
>>
> It's true that S400 using RGMII interface.
>
> but, we have customer using RTL8201FR-VB/VD which is a RMII PHY,
>
> This is actually tested with the 'eth_rmii_x_pins' group.
>
> Yixun
>

I pushed the same for GXBB,

Acked-by: Neil Armstrong <[email protected]>

2018-01-31 00:58:54

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH] ARM64: dts: meson-axg: add RMII pins for ethernet controller

Neil Armstrong <[email protected]> writes:

> On 11/01/2018 10:11, Yixun Lan wrote:
>> Hi Jerome:
>>
>> On 01/11/18 16:37, Jerome Brunet wrote:
>>> On Thu, 2018-01-11 at 11:04 +0800, Yixun Lan wrote:
>>>> Comparing to RGMII interface, the RMII interface require few pins.
>>>> So it's worth describing them here.
>>>>
>>>> Signed-off-by: Yixun Lan <[email protected]>
>>>
>>> The only axg platform we have upstream is the s400 and is using rgmii.
>>> May I ask how this was tested ?
>>>
>> It's true that S400 using RGMII interface.
>>
>> but, we have customer using RTL8201FR-VB/VD which is a RMII PHY,
>>
>> This is actually tested with the 'eth_rmii_x_pins' group.
>>
>> Yixun
>>
>
> I pushed the same for GXBB,
>
> Acked-by: Neil Armstrong <[email protected]>

Applied to v4.17/dt64 with Neil's ack.

Kevin