2018-01-17 03:48:15

by Dou Liyang

Subject: [PATCH] mm/page_poison: Make early_page_poison_param __init

The early_param() is only called during kernel initialization, So Linux
marks the function of it with __init macro to save memory.

But it forgot to mark the early_page_poison_param(). So, Make it __init
as well.

Cc: Andrew Morton <[email protected]>
Cc: Philippe Ombredanne <[email protected]>
Cc: Kate Stewart <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: [email protected]
Signed-off-by: Dou Liyang <[email protected]>
---
mm/page_poison.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_poison.c b/mm/page_poison.c
index e83fd44867de..aa2b3d34e8ea 100644
--- a/mm/page_poison.c
+++ b/mm/page_poison.c
@@ -9,7 +9,7 @@

static bool want_page_poisoning __read_mostly;

-static int early_page_poison_param(char *buf)
+static int __init early_page_poison_param(char *buf)
{
if (!buf)
return -EINVAL;
--
2.14.3

2018-02-21 16:10:05

by Michal Hocko

Subject: Re: [PATCH] mm/page_poison: Make early_page_poison_param __init

On Wed 17-01-18 11:47:57, Dou Liyang wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the function of it with __init macro to save memory.
>
> But it forgot to mark the early_page_poison_param(). So, Make it __init
> as well.
>
> Cc: Andrew Morton <[email protected]>
> Cc: Philippe Ombredanne <[email protected]>
> Cc: Kate Stewart <[email protected]>
> Cc: Michal Hocko <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: [email protected]
> Signed-off-by: Dou Liyang <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> mm/page_poison.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_poison.c b/mm/page_poison.c
> index e83fd44867de..aa2b3d34e8ea 100644
> --- a/mm/page_poison.c
> +++ b/mm/page_poison.c
> @@ -9,7 +9,7 @@
>
> static bool want_page_poisoning __read_mostly;
>
> -static int early_page_poison_param(char *buf)
> +static int __init early_page_poison_param(char *buf)
> {
> if (!buf)
> return -EINVAL;
> --
> 2.14.3
>
>
>

--
Michal Hocko
SUSE Labs