2018-01-18 15:10:26

by Christopher Díaz Riveros

Subject: [PATCH-next] MEMCG: memcontrol: make local symbol static

Fixes the following sparse warning:

mm/memcontrol.c:1097:14: warning:
symbol 'memcg1_stats' was not declared. Should it be static?

Signed-off-by: Christopher Díaz Riveros <[email protected]>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c3d1eaef752d..396674fd97ef 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
return false;
}

-unsigned int memcg1_stats[] = {
+static unsigned int memcg1_stats[] = {
MEMCG_CACHE,
MEMCG_RSS,
MEMCG_RSS_HUGE,
--
2.15.1

2018-01-18 15:17:08

by Joe Perches

Subject: Re: [PATCH-next] MEMCG: memcontrol: make local symbol static

On Thu, 2018-01-18 at 10:08 -0500, Christopher D?az Riveros wrote:
> Fixes the following sparse warning:
>
> mm/memcontrol.c:1097:14: warning:
> symbol 'memcg1_stats' was not declared. Should it be static?
>
> Signed-off-by: Christopher D?az Riveros <[email protected]>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
[]
> @@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
> return false;
> }
>
> -unsigned int memcg1_stats[] = {
> +static unsigned int memcg1_stats[] = {

This should almost certainly be static const

> MEMCG_CACHE,
> MEMCG_RSS,
> MEMCG_RSS_HUGE,

2018-01-18 19:24:32

by Joe Perches

Subject: Re: [PATCH-next] MEMCG: memcontrol: make local symbol static

On Thu, 2018-01-18 at 10:08 -0500, Christopher D?az Riveros wrote:
> Fixes the following sparse warning:
>
> mm/memcontrol.c:1097:14: warning:
> symbol 'memcg1_stats' was not declared. Should it be static?
>
> Signed-off-by: Christopher D?az Riveros <[email protected]>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
[]
> @@ -1094,7 +1094,7 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
> return false;
> }
>
> -unsigned int memcg1_stats[] = {
> +static unsigned int memcg1_stats[] = {

This should almost certainly be static const

> MEMCG_CACHE,
> MEMCG_RSS,
> MEMCG_RSS_HUGE,