2018-01-18 23:55:43

by Gustavo A. R. Silva

Subject: [PATCH] ssb: return boolean instead of integer in ssb_dma_translation_special_bit

Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/ssb/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 65420a9..fdb89b6 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1116,7 +1116,7 @@ static bool ssb_dma_translation_special_bit(struct ssb_device *dev)
chip_id == 43231 || chip_id == 43222);
}

- return 0;
+ return false;
}

u32 ssb_dma_translation(struct ssb_device *dev)
--
2.7.4

2018-02-27 16:16:12

by Kalle Valo

Subject: Re: ssb: return boolean instead of integer in ssb_dma_translation_special_bit

"Gustavo A. R. Silva" <[email protected]> wrote:

> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

bd42cd022e44 ssb: return boolean instead of integer in ssb_dma_translation_special_bit

--
https://patchwork.kernel.org/patch/10174387/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches