2018-01-22 15:37:39

by Philippe Cornu

Subject: [PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

In the dsi panel example, clock names in the "clock-names"
field have been swapped:
* "pclk" (peripheral clock) is <&rcc 1 CLK_F469_DSI> on stm32f4
* "ref" (dsi phy pll ref clock) is <&clk_hse> on stm32f4

Signed-off-by: Philippe Cornu <[email protected]>
---
Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
index 029252253ad4..3eb1b48b47dd 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
@@ -98,7 +98,7 @@ Example 2: DSI panel
compatible = "st,stm32-dsi";
reg = <0x40016c00 0x800>;
clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
- clock-names = "ref", "pclk";
+ clock-names = "pclk", "ref";
resets = <&rcc STM32F4_APB2_RESET(DSI)>;
reset-names = "apb";

--
2.15.1

2018-01-29 23:16:01

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

On Mon, Jan 22, 2018 at 04:35:47PM +0100, Philippe Cornu wrote:
> In the dsi panel example, clock names in the "clock-names"
> field have been swapped:
> * "pclk" (peripheral clock) is <&rcc 1 CLK_F469_DSI> on stm32f4
> * "ref" (dsi phy pll ref clock) is <&clk_hse> on stm32f4
>
> Signed-off-by: Philippe Cornu <[email protected]>
> ---
> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <[email protected]>

2018-01-30 10:52:44

by Benjamin Gaignard

Subject: Re: [PATCH] dt-bindings: display: stm32: correct clock-names in dsi panel example

2018-01-30 0:15 GMT+01:00 Rob Herring <[email protected]>:
> On Mon, Jan 22, 2018 at 04:35:47PM +0100, Philippe Cornu wrote:
>> In the dsi panel example, clock names in the "clock-names"
>> field have been swapped:
>> * "pclk" (peripheral clock) is <&rcc 1 CLK_F469_DSI> on stm32f4
>> * "ref" (dsi phy pll ref clock) is <&clk_hse> on stm32f4
>>
>> Signed-off-by: Philippe Cornu <[email protected]>
>> ---
>> Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <[email protected]>
>
Applied on drm-misc-next.

Regards,
Benjamin