2018-01-15 08:40:28

by SF Markus Elfring

Subject: [PATCH] mfd/max8997: Delete an error message for a failed memory allocation in max8997_i2c_parse_dt_pdata()

From: Markus Elfring <[email protected]>
Date: Mon, 15 Jan 2018 09:35:17 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/max8997.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
index 2d6e2c392786..3f554c447521 100644
--- a/drivers/mfd/max8997.c
+++ b/drivers/mfd/max8997.c
@@ -148,10 +148,8 @@ static struct max8997_platform_data *max8997_i2c_parse_dt_pdata(
struct max8997_platform_data *pd;

pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
- if (!pd) {
- dev_err(dev, "could not allocate memory for pdata\n");
+ if (!pd)
return ERR_PTR(-ENOMEM);
- }

pd->ono = irq_of_parse_and_map(dev->of_node, 1);

--
2.15.1

2018-01-22 15:43:42

by Lee Jones

Subject: Re: [PATCH] mfd/max8997: Delete an error message for a failed memory allocation in max8997_i2c_parse_dt_pdata()

On Mon, 15 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Mon, 15 Jan 2018 09:35:17 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/max8997.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog