2018-01-22 22:59:00

by Gustavo A. R. Silva

Subject: [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
net/xfrm/xfrm_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 20b1e41..9f063c6 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -317,7 +317,7 @@ xfrm_get_type_offload(u8 proto, unsigned short family, bool try_load)

if (!type && try_load) {
request_module("xfrm-offload-%d-%d", family, proto);
- try_load = 0;
+ try_load = false;
goto retry;
}

--
2.7.4

2018-01-24 06:13:16

by Steffen Klassert

Subject: Re: [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload

On Mon, Jan 22, 2018 at 04:34:09PM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Patch applied, thanks!