LinuxLists.cc - [PATCH] ARM: dts: imx6sx: add pu power domain support

2018-01-23 07:35:45

Subject: [PATCH] ARM: dts: imx6sx: add pu power domain support

Add PU power domain support, GPU is the only
module inside PU power domain, and PU power
is supplied by LDO_SOC.

Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index fd78793..42ef4c6 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -188,6 +188,7 @@
<&clks IMX6SX_CLK_GPU>,
<&clks IMX6SX_CLK_GPU>;
clock-names = "bus", "core", "shader";
+ power-domains = <&pd_pu>;
};

dma_apbh: dma-apbh@1804000 {
@@ -767,6 +768,13 @@
#address-cells = <1>;
#size-cells = <0>;

+ pd_pu: power-domain@1 {
+ reg = <1>;
+ #power-domain-cells = <0>;
+ power-supply = <&reg_soc>;
+ clocks = <&clks IMX6SX_CLK_GPU>;
+ };
+
pd_pci: power-domain@3 {
reg = <3>;
#power-domain-cells = <0>;
--
2.7.4

2018-01-25 15:32:51

by Dong Aisheng

[permalink] [raw]

Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only
> module inside PU power domain, and PU power
> is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <&reg_soc>;

I wonder we may not need this as it's a non-stop domain
just like we did for arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng <[email protected]>

Regards
Dong Aisheng

> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>

2018-01-26 06:33:19

by Anson Huang

[permalink] [raw]

Subject: RE: [PATCH] ARM: dts: imx6sx: add pu power domain support

-----Original Message-----
From: Dong Aisheng [mailto:[email protected]]
Sent: 2018??1??25?? 23:30
To: Anson Huang <[email protected]>
Cc: [email protected]; [email protected]; Fabio Estevam <[email protected]>; [email protected]; A.s. Dong <[email protected]>; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power
> domain, and PU power is supplied by LDO_SOC.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
> <&clks IMX6SX_CLK_GPU>,
> <&clks IMX6SX_CLK_GPU>;
> clock-names = "bus", "core", "shader";
> + power-domains = <&pd_pu>;
> };
>
> dma_apbh: dma-apbh@1804000 {
> @@ -767,6 +768,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pd_pu: power-domain@1 {
> + reg = <1>;
> + #power-domain-cells = <0>;
> + power-supply = <&reg_soc>;

I wonder we may not need this as it's a non-stop domain just like we did for arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng <[email protected]>

No, this domain can be power gated, there is an internal power gate in GPC, just the input
power can NOT be disabled. So there might be some leakage in this domain, but power still
can be saved a lot if internal power gate is off.

Anson.

Regards
Dong Aisheng

> + clocks = <&clks IMX6SX_CLK_GPU>;
> + };
> +
> pd_pci: power-domain@3 {
> reg = <3>;
> #power-domain-cells = <0>;
> --
> 2.7.4
>

2018-02-05 06:30:52

by Shawn Guo

[permalink] [raw]