2018-01-24 14:58:44

by Colin King

Subject: [PATCH] scsi: csiostor: remove redundant assignment to pointer 'ln'

From: Colin Ian King <[email protected]>

The pointer ln is assigned a value that is never read, it is re-assigned
a new value in the list_for_each loop hence the initialization is
redundant and can be removed.

Cleans up clang warning:
drivers/scsi/csiostor/csio_lnode.c:117:21: warning: Value stored to 'ln'
during its initialization is never read

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/csiostor/csio_lnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c
index be5ee2d37815..7dbbbb81a1e7 100644
--- a/drivers/scsi/csiostor/csio_lnode.c
+++ b/drivers/scsi/csiostor/csio_lnode.c
@@ -114,7 +114,7 @@ static enum csio_ln_ev fwevt_to_lnevt[] = {
static struct csio_lnode *
csio_ln_lookup_by_portid(struct csio_hw *hw, uint8_t portid)
{
- struct csio_lnode *ln = hw->rln;
+ struct csio_lnode *ln;
struct list_head *tmp;

/* Match siblings lnode with portid */
--
2.15.1

2018-01-29 15:17:06

by Varun Prakash

Subject: Re: [PATCH] scsi: csiostor: remove redundant assignment to pointer 'ln'

On Wed, Jan 24, 2018 at 02:58:01PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer ln is assigned a value that is never read, it is re-assigned
> a new value in the list_for_each loop hence the initialization is
> redundant and can be removed.
>
> Cleans up clang warning:
> drivers/scsi/csiostor/csio_lnode.c:117:21: warning: Value stored to 'ln'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/scsi/csiostor/csio_lnode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c
> index be5ee2d37815..7dbbbb81a1e7 100644
> --- a/drivers/scsi/csiostor/csio_lnode.c
> +++ b/drivers/scsi/csiostor/csio_lnode.c
> @@ -114,7 +114,7 @@ static enum csio_ln_ev fwevt_to_lnevt[] = {
> static struct csio_lnode *
> csio_ln_lookup_by_portid(struct csio_hw *hw, uint8_t portid)
> {
> - struct csio_lnode *ln = hw->rln;
> + struct csio_lnode *ln;
> struct list_head *tmp;
>
> /* Match siblings lnode with portid */

Acked-by: Varun Prakash <[email protected]>

2018-01-31 03:39:41

by Martin K. Petersen

Subject: Re: [PATCH] scsi: csiostor: remove redundant assignment to pointer 'ln'

Colin,

> The pointer ln is assigned a value that is never read, it is re-assigned
> a new value in the list_for_each loop hence the initialization is
> redundant and can be removed.

Applied to 4.16/scsi-fixes. Thank you.

--
Martin K. Petersen Oracle Linux Engineering