2018-01-29 19:34:40

by Larry Finger

Subject: [PATCH] macintosh: Add module license to ans-lcd

In kernel 4.15, the modprobe step on my PowerBook G5 started complaining that
there was no module license for ans-lcd.

Signed-off-by: Larry Finger <[email protected]>
---
drivers/macintosh/ans-lcd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index 1de81d922d8a..c8e078b911c7 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -201,3 +201,4 @@ anslcd_exit(void)

module_init(anslcd_init);
module_exit(anslcd_exit);
+MODULE_LICENSE("GPL v2");
--
2.16.1

2018-01-29 23:00:32

by Gabriel Paubert

Subject: Re: [PATCH] macintosh: Add module license to ans-lcd

On Mon, Jan 29, 2018 at 01:33:08PM -0600, Larry Finger wrote:
> In kernel 4.15, the modprobe step on my PowerBook G5 started complaining that

PowerBook G5? Really, could you send a pic! :-)

> there was no module license for ans-lcd.
>
> Signed-off-by: Larry Finger <[email protected]>
> ---
> drivers/macintosh/ans-lcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
> index 1de81d922d8a..c8e078b911c7 100644
> --- a/drivers/macintosh/ans-lcd.c
> +++ b/drivers/macintosh/ans-lcd.c
> @@ -201,3 +201,4 @@ anslcd_exit(void)
>
> module_init(anslcd_init);
> module_exit(anslcd_exit);
> +MODULE_LICENSE("GPL v2");
> --
> 2.16.1
>

2018-01-30 01:04:02

by Larry Finger

Subject: Re: [PATCH] macintosh: Add module license to ans-lcd

On 01/29/2018 04:49 PM, Gabriel Paubert wrote:
> On Mon, Jan 29, 2018 at 01:33:08PM -0600, Larry Finger wrote:
>> In kernel 4.15, the modprobe step on my PowerBook G5 started complaining that
>
> PowerBook G5? Really, could you send a pic! :-)

That was a typo. It is a G4 Aluminum.

Larry

2018-01-30 05:30:39

by Daniel Axtens

Subject: Re: [PATCH] macintosh: Add module license to ans-lcd

Hi,

That matches the SPDX identifier from the top of the file, so:

Reviewed-by: Daniel Axtens <[email protected]>

Regards,
Daniel

Larry Finger <[email protected]> writes:

> In kernel 4.15, the modprobe step on my PowerBook G5 started complaining that
> there was no module license for ans-lcd.
>
> Signed-off-by: Larry Finger <[email protected]>
> ---
> drivers/macintosh/ans-lcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
> index 1de81d922d8a..c8e078b911c7 100644
> --- a/drivers/macintosh/ans-lcd.c
> +++ b/drivers/macintosh/ans-lcd.c
> @@ -201,3 +201,4 @@ anslcd_exit(void)
>
> module_init(anslcd_init);
> module_exit(anslcd_exit);
> +MODULE_LICENSE("GPL v2");
> --
> 2.16.1