Hi!
The TSE-850 and the Nattis are using se97b chips from NXP. Previously,
these have been specified as compatible to "nxp,24c02". But the updated
bindings for the at24 eeproms makes me think that the right thing to
do is to have their compatible be
"nxp,se97b", "atmel,24c02"
This series takes care of that, and throws in a sorting patch while at it.
Cheers,
Peter
Peter Rosin (4):
dt-bindings: at24: sort manufacturers alphabetically
dt-bindings: at24: add compatible for nxp,se97b
ARM: dts: at91: nattis: use the correct compatible for the eeprom
ARM: dts: at91: tse850: use the correct compatible for the eeprom
Documentation/devicetree/bindings/eeprom/at24.txt | 3 ++-
arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
--
2.11.0
Makes them easier to find.
Signed-off-by: Peter Rosin <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 1812c848e369..abfae1beca2b 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -38,9 +38,9 @@ Required properties:
"catalyst",
"microchip",
+ "nxp",
"ramtron",
"renesas",
- "nxp",
"st",
Some vendors use different model names for chips which are just
--
2.11.0
The used part does contain an eeprom compatible with an Atmel 24c02
chip and it is from NXP, but it is not called 24c02. It's actually a
se97b chip. Adjust the compatible accordingly.
Fixes: 21dd0ece34c2 ("ARM: dts: at91: add devicetree for the Axentia TSE-850")
Signed-off-by: Peter Rosin <[email protected]>
---
arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
index 9b82cc8843e1..97b227693658 100644
--- a/arch/arm/boot/dts/at91-tse850-3.dts
+++ b/arch/arm/boot/dts/at91-tse850-3.dts
@@ -246,7 +246,7 @@
};
eeprom@50 {
- compatible = "nxp,24c02", "atmel,24c02";
+ compatible = "nxp,se97b", "atmel,24c02";
reg = <0x50>;
pagesize = <16>;
};
--
2.11.0
The used part does contain an eeprom compatible with an Atmel 24c02
chip and it is from NXP, but it is not called 24c02. It's actually a
se97b chip. Adjust the compatible accordingly.
Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
Signed-off-by: Peter Rosin <[email protected]>
---
arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index 3ea1d26e1c68..c457eff25911 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -146,7 +146,7 @@
};
eeprom@50 {
- compatible = "nxp,24c02";
+ compatible = "nxp,se97b", "atmel,24c02";
reg = <0x50>;
pagesize = <16>;
};
--
2.11.0
The datasheet talks about the chip being an spd, but the chip is writable
so atmel,24c02 is more appropriate as fallback.
Signed-off-by: Peter Rosin <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index abfae1beca2b..edf9247613f6 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -46,6 +46,7 @@ Required properties:
Some vendors use different model names for chips which are just
variants of the above. Known such exceptions are listed below:
+ "nxp,se97b" - the fallback is "atmel,24c02",
"renesas,r1ex24002" - the fallback is "atmel,24c02"
- reg: The I2C address of the EEPROM.
--
2.11.0
2018-01-16 17:06 GMT+01:00 Peter Rosin <[email protected]>:
> Makes them easier to find.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 1812c848e369..abfae1beca2b 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -38,9 +38,9 @@ Required properties:
>
> "catalyst",
> "microchip",
> + "nxp",
> "ramtron",
> "renesas",
> - "nxp",
> "st",
>
> Some vendors use different model names for chips which are just
> --
> 2.11.0
>
Acked-by: Bartosz Golaszewski <[email protected]>
2018-01-16 17:06 GMT+01:00 Peter Rosin <[email protected]>:
> The datasheet talks about the chip being an spd, but the chip is writable
> so atmel,24c02 is more appropriate as fallback.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index abfae1beca2b..edf9247613f6 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -46,6 +46,7 @@ Required properties:
> Some vendors use different model names for chips which are just
> variants of the above. Known such exceptions are listed below:
>
> + "nxp,se97b" - the fallback is "atmel,24c02",
> "renesas,r1ex24002" - the fallback is "atmel,24c02"
>
> - reg: The I2C address of the EEPROM.
> --
> 2.11.0
>
Acked-by: Bartosz Golaszewski <[email protected]>
On Tue, Jan 16, 2018 at 05:06:15PM +0100, Peter Rosin wrote:
> Makes them easier to find.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This one should go into 4.16. I can apply after rc1 or apply to tree
with at24.txt changes queued.
Acked-by: Rob Herring <[email protected]>
Rob
On Tue, Jan 16, 2018 at 05:06:16PM +0100, Peter Rosin wrote:
> The datasheet talks about the chip being an spd, but the chip is writable
> so atmel,24c02 is more appropriate as fallback.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Rob Herring <[email protected]>
2018-01-29 17:17 GMT+01:00 Rob Herring <[email protected]>:
> On Tue, Jan 16, 2018 at 05:06:15PM +0100, Peter Rosin wrote:
>> Makes them easier to find.
>>
>> Signed-off-by: Peter Rosin <[email protected]>
>> ---
>> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This one should go into 4.16. I can apply after rc1 or apply to tree
> with at24.txt changes queued.
>
> Acked-by: Rob Herring <[email protected]>
>
> Rob
Wolfram,
can you take this via the i2c tree for 4.16?
Thanks,
Bartosz
On 16/01/2018 at 17:06:18 +0100, Peter Rosin wrote:
> The used part does contain an eeprom compatible with an Atmel 24c02
> chip and it is from NXP, but it is not called 24c02. It's actually a
> se97b chip. Adjust the compatible accordingly.
>
> Fixes: 21dd0ece34c2 ("ARM: dts: at91: add devicetree for the Axentia TSE-850")
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
On 16/01/2018 at 17:06:17 +0100, Peter Rosin wrote:
> The used part does contain an eeprom compatible with an Atmel 24c02
> chip and it is from NXP, but it is not called 24c02. It's actually a
> se97b chip. Adjust the compatible accordingly.
>
> Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
2018-02-21 10:11 GMT+01:00 Wolfram Sang <[email protected]>:
> On Mon, Jan 29, 2018 at 05:56:52PM +0100, Bartosz Golaszewski wrote:
>> 2018-01-29 17:17 GMT+01:00 Rob Herring <[email protected]>:
>> > On Tue, Jan 16, 2018 at 05:06:15PM +0100, Peter Rosin wrote:
>> >> Makes them easier to find.
>> >>
>> >> Signed-off-by: Peter Rosin <[email protected]>
>> >> ---
>> >> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > This one should go into 4.16. I can apply after rc1 or apply to tree
>> > with at24.txt changes queued.
>> >
>> > Acked-by: Rob Herring <[email protected]>
>> >
>> > Rob
>>
>> Wolfram,
>>
>> can you take this via the i2c tree for 4.16?
>
> I missed this mail because I leave at24 patches to you now.
> Please send pull requests for patches I shall take. Least room for
> confusion (I hope).
>
Will do. What about this (http://patchwork.ozlabs.org/patch/867169/)
one? It's part of a bigger series, do you want me to apply it to my
tree and provide you with an immutable branch?
Bart
On Mon, Jan 29, 2018 at 05:56:52PM +0100, Bartosz Golaszewski wrote:
> 2018-01-29 17:17 GMT+01:00 Rob Herring <[email protected]>:
> > On Tue, Jan 16, 2018 at 05:06:15PM +0100, Peter Rosin wrote:
> >> Makes them easier to find.
> >>
> >> Signed-off-by: Peter Rosin <[email protected]>
> >> ---
> >> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This one should go into 4.16. I can apply after rc1 or apply to tree
> > with at24.txt changes queued.
> >
> > Acked-by: Rob Herring <[email protected]>
> >
> > Rob
>
> Wolfram,
>
> can you take this via the i2c tree for 4.16?
I missed this mail because I leave at24 patches to you now.
Please send pull requests for patches I shall take. Least room for
confusion (I hope).
> Will do. What about this (http://patchwork.ozlabs.org/patch/867169/)
> one? It's part of a bigger series, do you want me to apply it to my
> tree and provide you with an immutable branch?
Well, I would accept it for 4.16 using the "plain new id" rule. So, if
you add it on top of Peter's sorting patch, totally fine by me.
If you want it in v4.17, ok, too. I'd think an immutable branch is not
needed. There is a fallback property in the DTS. So at worst, there will
be a DTS warning during the merge window which will be fixed at rc1 time.
Unless I overlooked something.
2018-02-21 10:40 GMT+01:00 Wolfram Sang <[email protected]>:
>
>> Will do. What about this (http://patchwork.ozlabs.org/patch/867169/)
>> one? It's part of a bigger series, do you want me to apply it to my
>> tree and provide you with an immutable branch?
>
> Well, I would accept it for 4.16 using the "plain new id" rule. So, if
> you add it on top of Peter's sorting patch, totally fine by me.
>
> If you want it in v4.17, ok, too. I'd think an immutable branch is not
> needed. There is a fallback property in the DTS. So at worst, there will
> be a DTS warning during the merge window which will be fixed at rc1 time.
>
> Unless I overlooked something.
>
Ok, I'll have some time during the weekend, so I'll send a PR for rc3.
Bart
> Ok, I'll have some time during the weekend, so I'll send a PR for rc3.
Well, I am away this weekend, so I just sent out my pull request. But we
can make it for rc4, no problem.
2018-02-23 11:32 GMT+01:00 Wolfram Sang <[email protected]>:
>
>> Ok, I'll have some time during the weekend, so I'll send a PR for rc3.
>
> Well, I am away this weekend, so I just sent out my pull request. But we
> can make it for rc4, no problem.
>
Yeah, I actually meant rc4.
Bart
2018-01-16 17:06 GMT+01:00 Peter Rosin <[email protected]>:
> Makes them easier to find.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 1812c848e369..abfae1beca2b 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -38,9 +38,9 @@ Required properties:
>
> "catalyst",
> "microchip",
> + "nxp",
> "ramtron",
> "renesas",
> - "nxp",
> "st",
>
> Some vendors use different model names for chips which are just
> --
> 2.11.0
>
Applied to for-current. Thanks.
2018-01-16 17:06 GMT+01:00 Peter Rosin <[email protected]>:
> The datasheet talks about the chip being an spd, but the chip is writable
> so atmel,24c02 is more appropriate as fallback.
>
> Signed-off-by: Peter Rosin <[email protected]>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index abfae1beca2b..edf9247613f6 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -46,6 +46,7 @@ Required properties:
> Some vendors use different model names for chips which are just
> variants of the above. Known such exceptions are listed below:
>
> + "nxp,se97b" - the fallback is "atmel,24c02",
> "renesas,r1ex24002" - the fallback is "atmel,24c02"
>
> - reg: The I2C address of the EEPROM.
> --
> 2.11.0
>
Applied to for-next, thanks.
Bart