2018-02-08 13:51:14

by Leo Yan

[permalink] [raw]
Subject: [PATCH] sched/cpufreq: Remove unused macro SUGOV_KTHREAD_PRIORITY

Since schedutil kernel thread directly set priority to 0, the macro
SUGOV_KTHREAD_PRIORITY is not used. So remove it.

Cc: Vikram Mulukutla <[email protected]>
Cc: Vincent Guittot <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Signed-off-by: Leo Yan <[email protected]>
---
kernel/sched/cpufreq_schedutil.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index dd062a1..7936f54 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -19,8 +19,6 @@

#include "sched.h"

-#define SUGOV_KTHREAD_PRIORITY 50
-
struct sugov_tunables {
struct gov_attr_set attr_set;
unsigned int rate_limit_us;
--
2.7.4



2018-02-08 14:07:24

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] sched/cpufreq: Remove unused macro SUGOV_KTHREAD_PRIORITY

On 08/02/2018 14:48, Leo Yan wrote:
> Since schedutil kernel thread directly set priority to 0, the macro
> SUGOV_KTHREAD_PRIORITY is not used. So remove it.
>
> Cc: Vikram Mulukutla <[email protected]>
> Cc: Vincent Guittot <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
> Signed-off-by: Leo Yan <[email protected]>

Acked-by: Daniel Lezcano <[email protected]>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


2018-02-08 14:07:47

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH] sched/cpufreq: Remove unused macro SUGOV_KTHREAD_PRIORITY

Forgot Cc'ing me ? :)

On Thu, Feb 8, 2018 at 7:18 PM, Leo Yan <[email protected]> wrote:
> Since schedutil kernel thread directly set priority to 0, the macro
> SUGOV_KTHREAD_PRIORITY is not used. So remove it.
>
> Cc: Vikram Mulukutla <[email protected]>
> Cc: Vincent Guittot <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
> Signed-off-by: Leo Yan <[email protected]>
> ---
> kernel/sched/cpufreq_schedutil.c | 2 --
> 1 file changed, 2 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

2018-02-08 15:25:06

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH] sched/cpufreq: Remove unused macro SUGOV_KTHREAD_PRIORITY

On Thu, Feb 08, 2018 at 07:34:54PM +0530, Viresh Kumar wrote:
> Forgot Cc'ing me ? :)

I meant to copy you, but I wrongly added Vikram :)

> On Thu, Feb 8, 2018 at 7:18 PM, Leo Yan <[email protected]> wrote:
> > Since schedutil kernel thread directly set priority to 0, the macro
> > SUGOV_KTHREAD_PRIORITY is not used. So remove it.
> >
> > Cc: Vikram Mulukutla <[email protected]>
> > Cc: Vincent Guittot <[email protected]>
> > Cc: Daniel Lezcano <[email protected]>
> > Signed-off-by: Leo Yan <[email protected]>
> > ---
> > kernel/sched/cpufreq_schedutil.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> Acked-by: Viresh Kumar <[email protected]>

Thanks for acking, Viresh and Daniel.

Subject: [tip:sched/urgent] sched/cpufreq: Remove unused SUGOV_KTHREAD_PRIORITY macro

Commit-ID: 43d1b29b27c76e7454cd6c85bec4d0e9cbb039f3
Gitweb: https://git.kernel.org/tip/43d1b29b27c76e7454cd6c85bec4d0e9cbb039f3
Author: Leo Yan <[email protected]>
AuthorDate: Thu, 8 Feb 2018 21:48:22 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Tue, 13 Feb 2018 13:04:03 +0100

sched/cpufreq: Remove unused SUGOV_KTHREAD_PRIORITY macro

Since schedutil kernel thread directly set priority to 0, the macro
SUGOV_KTHREAD_PRIORITY is not used. So remove it.

Signed-off-by: Leo Yan <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
Acked-by: Daniel Lezcano <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Rafael J . Wysocki <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Vikram Mulukutla <[email protected]>
Cc: Vincent Guittot <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/cpufreq_schedutil.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index dd062a1..7936f54 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -19,8 +19,6 @@

#include "sched.h"

-#define SUGOV_KTHREAD_PRIORITY 50
-
struct sugov_tunables {
struct gov_attr_set attr_set;
unsigned int rate_limit_us;