2018-02-10 15:33:07

by Stefan Agner

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: add Freescale pin controllers

Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer
and Sascha as reviewer.

Signed-off-by: Stefan Agner <[email protected]>
---
MAINTAINERS | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 82ad0eabce4f..fb672dfc519d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10768,6 +10768,17 @@ L: [email protected]
S: Supported
F: drivers/pinctrl/pinctrl-at91-pio4.*

+PIN CONTROLLER - FREESCALE
+M: Dong Aisheng <[email protected]>
+M: Fabio Estevam <[email protected]>
+M: Shawn Guo <[email protected]>
+M: Stefan Agner <[email protected]>
+R: Sascha Hauer <[email protected]>
+L: [email protected]
+S: Maintained
+F: drivers/pinctrl/freescale/*
+F: Documentation/devicetree/bindings/pinctrl/fsl,*
+
PIN CONTROLLER - INTEL
M: Mika Westerberg <[email protected]>
M: Heikki Krogerus <[email protected]>
--
2.16.1



2018-02-10 16:29:07

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

On Sat, Feb 10, 2018 at 1:32 PM, Stefan Agner <[email protected]> wrote:
> Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer
> and Sascha as reviewer.
>
> Signed-off-by: Stefan Agner <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>

2018-02-12 11:37:10

by Lucas Stach

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach:
> Hi Lucas,
>
> On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote:
> > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
> > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as
> > > maintainer
> > > and Sascha as reviewer.
> > >
> > > Signed-off-by: Stefan Agner <[email protected]>
> > > ---
> > >  MAINTAINERS | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 82ad0eabce4f..fb672dfc519d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -10768,6 +10768,17 @@ L: [email protected]
> > >  S: Supported
> > >  F: drivers/pinctrl/pinctrl-at91-pio4.*
> > >  
> > > +PIN CONTROLLER - FREESCALE
> > > +M: Dong Aisheng <[email protected]>
> > > +M: Fabio Estevam <[email protected]>
> > > +M: Shawn Guo <[email protected]>
> > > +M: Stefan Agner <[email protected]>
> > > +R: Sascha Hauer <[email protected]>
> >
> > I'm fine with the patch, but it might make sense to clarify this a
> > bit:
> > the kernel@ address is really the whole Pengutronix kernel team,
> > not
> > just Sascha. Using this address is totally fine if you expect
> > comments
> > on patches, as it gives them a quite wide exposure inside of PTX.
>
> Of the 5 mentions of [email protected] in MAINTAINERS as of
> v4.16-rc1, 
> three name Sascha, and two name Uwe. Would you like to also clarify
> those?

I think it fine to keep the names of the individual people where they
maintain stuff, as this is usually bound to a single person (where
kernel@ address is only used for the exposure benefits), but I think it
makes less sense for the reviewer role.

Regards,
Lucas

2018-02-12 12:57:49

by Lucas Stach

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
> Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer
> and Sascha as reviewer.
>
> Signed-off-by: Stefan Agner <[email protected]>
> ---
>  MAINTAINERS | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 82ad0eabce4f..fb672dfc519d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10768,6 +10768,17 @@ L: [email protected]
>  S: Supported
>  F: drivers/pinctrl/pinctrl-at91-pio4.*
>  
> +PIN CONTROLLER - FREESCALE
> +M: Dong Aisheng <[email protected]>
> +M: Fabio Estevam <[email protected]>
> +M: Shawn Guo <[email protected]>
> +M: Stefan Agner <[email protected]>
> +R: Sascha Hauer <[email protected]>

I'm fine with the patch, but it might make sense to clarify this a bit:
the kernel@ address is really the whole Pengutronix kernel team, not
just Sascha. Using this address is totally fine if you expect comments
on patches, as it gives them a quite wide exposure inside of PTX.

Regards,
Lucas

> +L: [email protected]
> +S: Maintained
> +F: drivers/pinctrl/freescale/*
> +F: Documentation/devicetree/bindings/pinctrl/fsl,*
> +
>  PIN CONTROLLER - INTEL
>  M: Mika Westerberg <[email protected]>
>  M: Heikki Krogerus <[email protected]>

2018-02-12 13:21:28

by Baruch Siach

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

Hi Lucas,

On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote:
> Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
> > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer
> > and Sascha as reviewer.
> >
> > Signed-off-by: Stefan Agner <[email protected]>
> > ---
> > ?MAINTAINERS | 11 +++++++++++
> > ?1 file changed, 11 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 82ad0eabce4f..fb672dfc519d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10768,6 +10768,17 @@ L: [email protected]
> > ?S: Supported
> > ?F: drivers/pinctrl/pinctrl-at91-pio4.*
> > ?
> > +PIN CONTROLLER - FREESCALE
> > +M: Dong Aisheng <[email protected]>
> > +M: Fabio Estevam <[email protected]>
> > +M: Shawn Guo <[email protected]>
> > +M: Stefan Agner <[email protected]>
> > +R: Sascha Hauer <[email protected]>
>
> I'm fine with the patch, but it might make sense to clarify this a bit:
> the kernel@ address is really the whole Pengutronix kernel team, not
> just Sascha. Using this address is totally fine if you expect comments
> on patches, as it gives them a quite wide exposure inside of PTX.

Of the 5 mentions of [email protected] in MAINTAINERS as of v4.16-rc1,
three name Sascha, and two name Uwe. Would you like to also clarify those?

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -

2018-02-12 16:48:26

by Stefan Agner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add Freescale pin controllers

On 12.02.2018 12:34, Lucas Stach wrote:
> Am Montag, den 12.02.2018, 13:22 +0200 schrieb Baruch Siach:
>> Hi Lucas,
>>
>> On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote:
>> > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner:
>> > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as
>> > > maintainer
>> > > and Sascha as reviewer.
>> > >
>> > > Signed-off-by: Stefan Agner <[email protected]>
>> > > ---
>> > >  MAINTAINERS | 11 +++++++++++
>> > >  1 file changed, 11 insertions(+)
>> > >
>> > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > index 82ad0eabce4f..fb672dfc519d 100644
>> > > --- a/MAINTAINERS
>> > > +++ b/MAINTAINERS
>> > > @@ -10768,6 +10768,17 @@ L: [email protected]
>> > >  S: Supported
>> > >  F: drivers/pinctrl/pinctrl-at91-pio4.*
>> > >  
>> > > +PIN CONTROLLER - FREESCALE
>> > > +M: Dong Aisheng <[email protected]>
>> > > +M: Fabio Estevam <[email protected]>
>> > > +M: Shawn Guo <[email protected]>
>> > > +M: Stefan Agner <[email protected]>
>> > > +R: Sascha Hauer <[email protected]>
>> >
>> > I'm fine with the patch, but it might make sense to clarify this a
>> > bit:
>> > the kernel@ address is really the whole Pengutronix kernel team,
>> > not
>> > just Sascha. Using this address is totally fine if you expect
>> > comments
>> > on patches, as it gives them a quite wide exposure inside of PTX.
>>
>> Of the 5 mentions of [email protected] in MAINTAINERS as of
>> v4.16-rc1, 
>> three name Sascha, and two name Uwe. Would you like to also clarify
>> those?
>
> I think it fine to keep the names of the individual people where they
> maintain stuff, as this is usually bound to a single person (where
> kernel@ address is only used for the exposure benefits), but I think it
> makes less sense for the reviewer role.

Sounds reasonable, I will send a v2 with:
R: Pengutronix Kernel Team <[email protected]>

--
Stefan

>
> Regards,
> Lucas