2018-02-13 19:36:05

by Alexey Brodkin

Subject: [PATCH] ARC: Don't check presense of Timer1 in SMP builds

In case of SMP we use GFRC from ARconnect and Timer1 is left
untouched. Still with that check in place we're panicing if Timer1
is missing in current hardware which is quite unexpected.

Signed-off-by: Alexey Brodkin <[email protected]>
---
arch/arc/kernel/setup.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index cf97f7d88934..1142d76a7e8f 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
if (!cpu->extn.timer0)
panic("Timer0 is not present!\n");

+#ifndef CONFIG_SMP
if (!cpu->extn.timer1)
panic("Timer1 is not present!\n");
+#endif

#ifdef CONFIG_ARC_HAS_DCCM
/*
--
2.11.0

2018-02-13 19:54:41

by Vineet Gupta

Subject: Re: [PATCH] ARC: Don't check presense of Timer1 in SMP builds

On 02/13/2018 11:35 AM, Alexey Brodkin wrote:
> In case of SMP we use GFRC from ARconnect and Timer1 is left
> untouched. Still with that check in place we're panicing if Timer1
> is missing in current hardware which is quite unexpected.
>
> Signed-off-by: Alexey Brodkin <[email protected]>
> ---
> arch/arc/kernel/setup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cf97f7d88934..1142d76a7e8f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
> if (!cpu->extn.timer0)
> panic("Timer0 is not present!\n");
>
> +#ifndef CONFIG_SMP
> if (!cpu->extn.timer1)
> panic("Timer1 is not present!\n");
> +#endif

Curious, you have a config w/o TIMER1, so is this a fallout of recent discussions !

-Vineet