2018-01-16 14:45:36

by James Hogan

Subject: [PATCH] rtc: goldfish: Add missing MODULE_LICENSE

Fix the following warning in MIPS allmodconfig by adding a
MODULE_LICENSE() at the end of rtc-goldfish.c, based on the file header
comment which says GNU General Public License version 2:

WARNING: modpost: missing MODULE_LICENSE() in drivers/rtc/rtc-goldfish.o

Fixes: f22d9cdcb5eb ("rtc: goldfish: Add RTC driver for Android emulator")
Signed-off-by: James Hogan <[email protected]>
Cc: Miodrag Dinic <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: [email protected]
---
drivers/rtc/rtc-goldfish.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
index d67769265185..a1c44d0c8557 100644
--- a/drivers/rtc/rtc-goldfish.c
+++ b/drivers/rtc/rtc-goldfish.c
@@ -235,3 +235,5 @@ static struct platform_driver goldfish_rtc = {
};

module_platform_driver(goldfish_rtc);
+
+MODULE_LICENSE("GPL v2");
--
2.13.6

2018-02-13 20:49:29

by Alexandre Belloni

Subject: Re: [PATCH] rtc: goldfish: Add missing MODULE_LICENSE

On 16/01/2018 at 14:45:21 +0000, James Hogan wrote:
> Fix the following warning in MIPS allmodconfig by adding a
> MODULE_LICENSE() at the end of rtc-goldfish.c, based on the file header
> comment which says GNU General Public License version 2:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/rtc/rtc-goldfish.o
>
> Fixes: f22d9cdcb5eb ("rtc: goldfish: Add RTC driver for Android emulator")
> Signed-off-by: James Hogan <[email protected]>
> Cc: Miodrag Dinic <[email protected]>
> Cc: Alessandro Zummo <[email protected]>
> Cc: Alexandre Belloni <[email protected]>
> Cc: [email protected]
> ---
> drivers/rtc/rtc-goldfish.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com