2018-02-14 17:48:53

by Matteo Croce

Subject: [PATCH] bloat-o-meter: fix typo in help

the bloat-o-meter script has two typos in the help, fix both.

Fixes: 192efb7a1f9b ("bloat-o-meter: provide 3 different arguments for data, function and All")
Signed-off-by: Matteo Croce <[email protected]>
---
scripts/bloat-o-meter | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
index 94b664817ad9..d84a5674e95e 100755
--- a/scripts/bloat-o-meter
+++ b/scripts/bloat-o-meter
@@ -15,7 +15,7 @@ signal(SIGPIPE, SIG_DFL)
if len(sys.argv) < 3:
sys.stderr.write("usage: %s [option] file1 file2\n" % sys.argv[0])
sys.stderr.write("The options are:\n")
- sys.stderr.write("-c cateogrize output based on symbole type\n")
+ sys.stderr.write("-c categorize output based on symbol type\n")
sys.stderr.write("-d Show delta of Data Section\n")
sys.stderr.write("-t Show delta of text Section\n")
sys.exit(-1)
--
2.14.3

2018-03-07 23:41:28

by Matteo Croce

Subject: Re: [PATCH] bloat-o-meter: fix typo in help

On Wed, Feb 14, 2018 at 6:47 PM, Matteo Croce <[email protected]> wrote:
> the bloat-o-meter script has two typos in the help, fix both.
>
> Fixes: 192efb7a1f9b ("bloat-o-meter: provide 3 different arguments for data, function and All")
> Signed-off-by: Matteo Croce <[email protected]>
> ---
> scripts/bloat-o-meter | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
> index 94b664817ad9..d84a5674e95e 100755
> --- a/scripts/bloat-o-meter
> +++ b/scripts/bloat-o-meter
> @@ -15,7 +15,7 @@ signal(SIGPIPE, SIG_DFL)
> if len(sys.argv) < 3:
> sys.stderr.write("usage: %s [option] file1 file2\n" % sys.argv[0])
> sys.stderr.write("The options are:\n")
> - sys.stderr.write("-c cateogrize output based on symbole type\n")
> + sys.stderr.write("-c categorize output based on symbol type\n")
> sys.stderr.write("-d Show delta of Data Section\n")
> sys.stderr.write("-t Show delta of text Section\n")
> sys.exit(-1)
> --
> 2.14.3
>

Ping, anyone willing to review and eventually merge it?

Regards,
--
Matteo Croce
per aspera ad upstream

2018-03-08 01:53:11

by Randy Dunlap

Subject: Re: [PATCH] bloat-o-meter: fix typo in help

On 03/07/2018 03:39 PM, Matteo Croce wrote:
> On Wed, Feb 14, 2018 at 6:47 PM, Matteo Croce <[email protected]> wrote:
>> the bloat-o-meter script has two typos in the help, fix both.
>>
>> Fixes: 192efb7a1f9b ("bloat-o-meter: provide 3 different arguments for data, function and All")
>> Signed-off-by: Matteo Croce <[email protected]>
>> ---
>> scripts/bloat-o-meter | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
>> index 94b664817ad9..d84a5674e95e 100755
>> --- a/scripts/bloat-o-meter
>> +++ b/scripts/bloat-o-meter
>> @@ -15,7 +15,7 @@ signal(SIGPIPE, SIG_DFL)
>> if len(sys.argv) < 3:
>> sys.stderr.write("usage: %s [option] file1 file2\n" % sys.argv[0])
>> sys.stderr.write("The options are:\n")
>> - sys.stderr.write("-c cateogrize output based on symbole type\n")
>> + sys.stderr.write("-c categorize output based on symbol type\n")
>> sys.stderr.write("-d Show delta of Data Section\n")
>> sys.stderr.write("-t Show delta of text Section\n")
>> sys.exit(-1)
>> --
>> 2.14.3
>>
>
> Ping, anyone willing to review and eventually merge it?

Acked-by: Randy Dunlap <[email protected]>


Andrew or Masahiro?

thanks,
--
~Randy

2018-03-08 04:29:04

by Masahiro Yamada

Subject: Re: [PATCH] bloat-o-meter: fix typo in help

2018-03-08 10:51 GMT+09:00 Randy Dunlap <[email protected]>:
> On 03/07/2018 03:39 PM, Matteo Croce wrote:
>> On Wed, Feb 14, 2018 at 6:47 PM, Matteo Croce <[email protected]> wrote:
>>> the bloat-o-meter script has two typos in the help, fix both.
>>>
>>> Fixes: 192efb7a1f9b ("bloat-o-meter: provide 3 different arguments for data, function and All")
>>> Signed-off-by: Matteo Croce <[email protected]>
>>> ---
>>> scripts/bloat-o-meter | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
>>> index 94b664817ad9..d84a5674e95e 100755
>>> --- a/scripts/bloat-o-meter
>>> +++ b/scripts/bloat-o-meter
>>> @@ -15,7 +15,7 @@ signal(SIGPIPE, SIG_DFL)
>>> if len(sys.argv) < 3:
>>> sys.stderr.write("usage: %s [option] file1 file2\n" % sys.argv[0])
>>> sys.stderr.write("The options are:\n")
>>> - sys.stderr.write("-c cateogrize output based on symbole type\n")
>>> + sys.stderr.write("-c categorize output based on symbol type\n")
>>> sys.stderr.write("-d Show delta of Data Section\n")
>>> sys.stderr.write("-t Show delta of text Section\n")
>>> sys.exit(-1)
>>> --
>>> 2.14.3
>>>
>>
>> Ping, anyone willing to review and eventually merge it?
>
> Acked-by: Randy Dunlap <[email protected]>
>
>
> Andrew or Masahiro?
>
> thanks,
> --
> ~Randy

I will pick up this shortly. Thanks!



--
Best Regards
Masahiro Yamada

2018-03-08 16:14:18

by Masahiro Yamada

Subject: Re: [PATCH] bloat-o-meter: fix typo in help

2018-03-08 8:39 GMT+09:00 Matteo Croce <[email protected]>:
> On Wed, Feb 14, 2018 at 6:47 PM, Matteo Croce <[email protected]> wrote:
>> the bloat-o-meter script has two typos in the help, fix both.
>>
>> Fixes: 192efb7a1f9b ("bloat-o-meter: provide 3 different arguments for data, function and All")
>> Signed-off-by: Matteo Croce <[email protected]>
>> ---
>> scripts/bloat-o-meter | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
>> index 94b664817ad9..d84a5674e95e 100755
>> --- a/scripts/bloat-o-meter
>> +++ b/scripts/bloat-o-meter
>> @@ -15,7 +15,7 @@ signal(SIGPIPE, SIG_DFL)
>> if len(sys.argv) < 3:
>> sys.stderr.write("usage: %s [option] file1 file2\n" % sys.argv[0])
>> sys.stderr.write("The options are:\n")
>> - sys.stderr.write("-c cateogrize output based on symbole type\n")
>> + sys.stderr.write("-c categorize output based on symbol type\n")
>> sys.stderr.write("-d Show delta of Data Section\n")
>> sys.stderr.write("-t Show delta of text Section\n")
>> sys.exit(-1)
>> --
>> 2.14.3
>>
>
> Ping, anyone willing to review and eventually merge it?
>
> Regards,
> --
> Matteo Croce
> per aspera ad upstream

Applied to linux-kbuild/fixes. Thanks!


--
Best Regards
Masahiro Yamada