2018-02-18 08:59:04

by Kai-Heng Feng

[permalink] [raw]
Subject: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

Similar to commit e10aec652f31 ("drm/edid: Add 6 bpc quirk for display
AEO model 0."), the EDID reports "DFP 1.x compliant TMDS" but it support
6bpc instead of 8 bpc.

Hence, use 6 bpc quirk for this panel.

Fixes: 196f954e2509 ("drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"")
BugLink: https://bugs.launchpad.net/bugs/1749420
Signed-off-by: Kai-Heng Feng <[email protected]>
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ddd537914575..d9c8d718e261 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -113,6 +113,9 @@ static const struct edid_quirk {
/* AEO model 0 reports 8 bpc, but is a 6 bpc panel */
{ "AEO", 0, EDID_QUIRK_FORCE_6BPC },

+ /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */
+ { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC },
+
/* Belinea 10 15 55 */
{ "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
{ "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },
--
2.15.1



2018-02-18 12:21:40

by Mario Kleiner

[permalink] [raw]
Subject: Re: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

On 02/18/2018 09:53 AM, Kai-Heng Feng wrote:
> Similar to commit e10aec652f31 ("drm/edid: Add 6 bpc quirk for display
> AEO model 0."), the EDID reports "DFP 1.x compliant TMDS" but it support
> 6bpc instead of 8 bpc.
>
> Hence, use 6 bpc quirk for this panel.
>
> Fixes: 196f954e2509 ("drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"")
> BugLink: https://bugs.launchpad.net/bugs/1749420
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> drivers/gpu/drm/drm_edid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd537914575..d9c8d718e261 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -113,6 +113,9 @@ static const struct edid_quirk {
> /* AEO model 0 reports 8 bpc, but is a 6 bpc panel */
> { "AEO", 0, EDID_QUIRK_FORCE_6BPC },
>
> + /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */
> + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC },
> +
> /* Belinea 10 15 55 */
> { "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
> { "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },
>

Reviewed-by: Mario Kleiner <[email protected]>

2018-02-19 10:43:56

by Jani Nikula

[permalink] [raw]
Subject: Re: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

On Sun, 18 Feb 2018, Kai-Heng Feng <[email protected]> wrote:
> Similar to commit e10aec652f31 ("drm/edid: Add 6 bpc quirk for display
> AEO model 0."), the EDID reports "DFP 1.x compliant TMDS" but it support
> 6bpc instead of 8 bpc.
>
> Hence, use 6 bpc quirk for this panel.
>
> Fixes: 196f954e2509 ("drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"")

Implies

Cc: <[email protected]> # v4.8+

> BugLink: https://bugs.launchpad.net/bugs/1749420
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> drivers/gpu/drm/drm_edid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index ddd537914575..d9c8d718e261 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -113,6 +113,9 @@ static const struct edid_quirk {
> /* AEO model 0 reports 8 bpc, but is a 6 bpc panel */
> { "AEO", 0, EDID_QUIRK_FORCE_6BPC },
>
> + /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */
> + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC },
> +
> /* Belinea 10 15 55 */
> { "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 },
> { "MAX", 0x77e, EDID_QUIRK_PREFER_LARGE_60 },

--
Jani Nikula, Intel Open Source Technology Center