2018-02-23 17:18:35

by Colin King

[permalink] [raw]
Subject: [PATCH][next] xen-netback: make function xenvif_rx_skb static

From: Colin Ian King <[email protected]>

The function xenvif_rx_skb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/xen-netback/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c
index b1cf7c6f407a..ef5887037b22 100644
--- a/drivers/net/xen-netback/rx.c
+++ b/drivers/net/xen-netback/rx.c
@@ -419,7 +419,7 @@ static void xenvif_rx_extra_slot(struct xenvif_queue *queue,
BUG();
}

-void xenvif_rx_skb(struct xenvif_queue *queue)
+static void xenvif_rx_skb(struct xenvif_queue *queue)
{
struct xenvif_pkt_state pkt;

--
2.15.1



2018-02-23 17:44:52

by Wei Liu

[permalink] [raw]
Subject: Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

On Fri, Feb 23, 2018 at 05:16:57PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The function xenvif_rx_skb is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Wei Liu <[email protected]>

Thanks

2018-02-26 16:39:33

by David Miller

[permalink] [raw]
Subject: Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

From: Colin King <[email protected]>
Date: Fri, 23 Feb 2018 17:16:57 +0000

> From: Colin Ian King <[email protected]>
>
> The function xenvif_rx_skb is local to the source and does not need
> to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied.