2018-02-26 18:31:41

by Liang, Kan

Subject: [PATCH] perf top: Fix annoying fallback message on older kernel

From: Kan Liang <[email protected]>

On older (v4.4) kernels, the annoying fallback message can be observed
in 'perf top'.

The 'perf top' has been changed to overwrite mode since
'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")'
For the older kernels which don't have overwrite mode support, the 'perf
top' will fall back to non-overwrite mode and print out the fallback
message by ui__warning, which needs user's input to close.

The fallback message is not critical message for end users. Turning it
to debug message which is printed when running with -vv.

Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Reported-by: Ingo Molnar <[email protected]>
Signed-off-by: Kan Liang <[email protected]>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823b..35ac016 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}

--
2.7.4

2018-02-26 19:21:50

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf top: Fix annoying fallback message on older kernel

Em Mon, Feb 26, 2018 at 10:17:10AM -0800, [email protected] escreveu:
> The fallback message is not critical message for end users. Turning it
> to debug message which is printed when running with -vv.

> Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
> Reported-by: Ingo Molnar <[email protected]>

Thanks, applied.

- Arnaldo

2018-02-27 06:55:38

by Ingo Molnar

Subject: Re: [PATCH] perf top: Fix annoying fallback message on older kernel

* [email protected] <[email protected]> wrote:

> From: Kan Liang <[email protected]>
>
> On older (v4.4) kernels, the annoying fallback message can be observed
> in 'perf top'.
>
> The 'perf top' has been changed to overwrite mode since
> 'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")'
> For the older kernels which don't have overwrite mode support, the 'perf
> top' will fall back to non-overwrite mode and print out the fallback
> message by ui__warning, which needs user's input to close.
>
> The fallback message is not critical message for end users. Turning it
> to debug message which is printed when running with -vv.
>
> Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
> Reported-by: Ingo Molnar <[email protected]>
> Signed-off-by: Kan Liang <[email protected]>
> ---
> tools/perf/builtin-top.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index b7c823b..35ac016 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
> evlist__for_each_entry(evlist, counter)
> counter->attr.write_backward = false;
> opts->overwrite = false;
> - ui__warning("fall back to non-overwrite mode\n");
> + pr_debug2("fall back to non-overwrite mode\n");
> return 1;
> }

Thanks!

Ingo

2018-03-06 06:43:52

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf top: Fix annoying fallback message on older kernels

Commit-ID: 853745f5e6d95faaae6381c9a01dbd43de992fb3
Gitweb: https://git.kernel.org/tip/853745f5e6d95faaae6381c9a01dbd43de992fb3
Author: Kan Liang <[email protected]>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 26 Feb 2018 16:04:08 -0300

perf top: Fix annoying fallback message on older kernels

On older (e.g. v4.4) kernels, an annoying fallback message can be
observed in 'perf top':

┌─Warning:──────────────────────┐
│fall back to non-overwrite mode│
│ │
│ │
│Press any key... │
└───────────────────────────────┘

The 'perf top' utility has been changed to overwrite mode since commit
ebebbf082357 ("perf top: Switch default mode to overwrite mode").

For older kernels which don't have overwrite mode support, 'perf top'
will fall back to non-overwrite mode and print out the fallback message
using ui__warning(), which needs user's input to close.

The fallback message is not critical for end users. Turning it to debug
message which is printed when running with -vv.

Reported-by: Ingo Molnar <[email protected]>
Signed-off-by: Kan Liang <[email protected]>
Cc: Kan Liang <[email protected]>
Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823ba8374..35ac016fcb98 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}

2018-03-07 08:27:43

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf top: Fix annoying fallback message on older kernels

Commit-ID: 626af862da9c650e80bdea44684be9334f8eb75b
Gitweb: https://git.kernel.org/tip/626af862da9c650e80bdea44684be9334f8eb75b
Author: Kan Liang <[email protected]>
AuthorDate: Mon, 26 Feb 2018 10:17:10 -0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 5 Mar 2018 11:48:56 -0300

perf top: Fix annoying fallback message on older kernels

On older (e.g. v4.4) kernels, an annoying fallback message can be
observed in 'perf top':

┌─Warning:──────────────────────┐
│fall back to non-overwrite mode│
│ │
│ │
│Press any key... │
└───────────────────────────────┘

The 'perf top' utility has been changed to overwrite mode since commit
ebebbf082357 ("perf top: Switch default mode to overwrite mode").

For older kernels which don't have overwrite mode support, 'perf top'
will fall back to non-overwrite mode and print out the fallback message
using ui__warning(), which needs user's input to close.

The fallback message is not critical for end users. Turning it to debug
message which is printed when running with -vv.

Reported-by: Ingo Molnar <[email protected]>
Signed-off-by: Kan Liang <[email protected]>
Cc: Kan Liang <[email protected]>
Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823ba8374..35ac016fcb98 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
evlist__for_each_entry(evlist, counter)
counter->attr.write_backward = false;
opts->overwrite = false;
- ui__warning("fall back to non-overwrite mode\n");
+ pr_debug2("fall back to non-overwrite mode\n");
return 1;
}