2018-02-27 11:50:13

by Christophe Leroy

Subject: [PATCH] powerpc/8xx: fix cpm_cascade() dual end of interrupt

cpm_cascade() doesn't have to call eoi() as it is already called
by handle_fasteoi_irq()

And cpm_get_irq() will always return an unsigned int so the test
is useless

Signed-off-by: Christophe Leroy <[email protected]>
---
arch/powerpc/platforms/8xx/m8xx_setup.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/powerpc/platforms/8xx/m8xx_setup.c b/arch/powerpc/platforms/8xx/m8xx_setup.c
index e1274db53d48..2188d691a40f 100644
--- a/arch/powerpc/platforms/8xx/m8xx_setup.c
+++ b/arch/powerpc/platforms/8xx/m8xx_setup.c
@@ -217,13 +217,7 @@ void __noreturn mpc8xx_restart(char *cmd)

static void cpm_cascade(struct irq_desc *desc)
{
- struct irq_chip *chip = irq_desc_get_chip(desc);
- int cascade_irq = cpm_get_irq();
-
- if (cascade_irq >= 0)
- generic_handle_irq(cascade_irq);
-
- chip->irq_eoi(&desc->irq_data);
+ generic_handle_irq(cpm_get_irq());
}

/* Initialize the internal interrupt controllers. The number of
--
2.13.3

2018-03-14 09:31:43

by Michael Ellerman

Subject: Re: powerpc/8xx: fix cpm_cascade() dual end of interrupt

On Tue, 2018-02-27 at 11:25:55 UTC, Christophe Leroy wrote:
> cpm_cascade() doesn't have to call eoi() as it is already called
> by handle_fasteoi_irq()
>
> And cpm_get_irq() will always return an unsigned int so the test
> is useless
>
> Signed-off-by: Christophe Leroy <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/c554ac91ce2213faa91c51c4542377

cheers