2018-03-01 20:20:55

by Shuah Khan

Subject: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

Add top level TAP header echo, testname and separator line to make
the output consistent with the common run_tests target.

This change prevents nested TAP13 headers output from individual tests.
Nested TAP13 headers could cause problems for some parsers.

Signed-off-by: Shuah Khan <[email protected]>
---
Changes since v1:
- Add export KSFT_TAP_LEVEL to fix nested TAP header problem
for "make -C" usecase
- Update commit log with details on nested TAP headers.

tools/testing/selftests/futex/Makefile | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index cea4adcd42b8..3006febb59fe 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -18,6 +18,10 @@ all:
done

override define RUN_TESTS
+ @export KSFT_TAP_LEVEL=`echo 1`;
+ @echo "TAP version 13";
+ @echo "selftests: futex";
+ @echo "========================================";
@cd $(OUTPUT); ./run.sh
endef

--
2.14.1

2018-03-06 00:19:50

by Darren Hart

Subject: Re: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

On Thu, Mar 01, 2018 at 01:19:07PM -0700, Shuah Khan wrote:
> Add top level TAP header echo, testname and separator line to make
> the output consistent with the common run_tests target.
>
> This change prevents nested TAP13 headers output from individual tests.
> Nested TAP13 headers could cause problems for some parsers.
>
> Signed-off-by: Shuah Khan <[email protected]>


Reviewed-by: Darren Hart (VMware) <[email protected]>


--
Darren Hart
VMware Open Source Technology Center

2018-03-07 02:39:19

by Shuah Khan

Subject: Re: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

On 03/05/2018 05:18 PM, Darren Hart wrote:
> On Thu, Mar 01, 2018 at 01:19:07PM -0700, Shuah Khan wrote:
>> Add top level TAP header echo, testname and separator line to make
>> the output consistent with the common run_tests target.
>>
>> This change prevents nested TAP13 headers output from individual tests.
>> Nested TAP13 headers could cause problems for some parsers.
>>
>> Signed-off-by: Shuah Khan <[email protected]>
>
>
> Reviewed-by: Darren Hart (VMware) <[email protected]>
>
>

Thanks. Queued this up with the rest for 4.17-rc1

-- Shuah