2018-03-03 19:11:01

by Arushi Singhal

Subject: [PATCH] staging: rtlwifi: Remove nonessential semicolon

Remove non-essential semicolon after 'else' and 'switch' statements. Issue
found using semicolon.cocci Coccinelle script.

Signed-off-by: Arushi Singhal <[email protected]>
---
drivers/staging/rtlwifi/base.c | 6 +++---
drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
index c947def..eea0003 100644
--- a/drivers/staging/rtlwifi/base.c
+++ b/drivers/staging/rtlwifi/base.c
@@ -710,20 +710,20 @@ u8 rtl_mrate_idx_to_arfr_id(
ret = RATEID_IDX_BGN_40M_1SS;
else
ret = RATEID_IDX_BGN_40M_2SS;
- ; break;
+ break;
case RATR_INX_WIRELESS_N:
case RATR_INX_WIRELESS_NG:
if (rtlphy->rf_type == RF_1T1R)
ret = RATEID_IDX_GN_N1SS;
else
ret = RATEID_IDX_GN_N2SS;
- ; break;
+ break;
case RATR_INX_WIRELESS_NB:
if (rtlphy->rf_type == RF_1T1R)
ret = RATEID_IDX_BGN_20M_1SS_BN;
else
ret = RATEID_IDX_BGN_20M_2SS_BN;
- ; break;
+ break;
case RATR_INX_WIRELESS_GB:
ret = RATEID_IDX_BG;
break;
diff --git a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
index 8c08c76..e10a91a 100644
--- a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
+++ b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
@@ -142,7 +142,6 @@ void odm_c2h_ra_para_report_handler(void *dm_void, u8 *cmd_buf, u8 cmd_len)
"SGI_support =", cmd_buf[7]);
ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE, "%5s %d\n",
"Rate_ID =", cmd_buf[8]);
- ;
}
ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE,
"-------------------------------\n");
--
2.7.4

2018-03-03 19:31:15

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH] staging: rtlwifi: Remove nonessential semicolon

On Sun, 4 Mar 2018, Arushi Singhal wrote:

> Remove non-essential semicolon after 'else' and 'switch' statements. Issue
> found using semicolon.cocci Coccinelle script.
>
> Signed-off-by: Arushi Singhal <[email protected]>

Acked-by: Julia Lawall <[email protected]>

It seems strange that someone would write code like that...

julia

> ---
> drivers/staging/rtlwifi/base.c | 6 +++---
> drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 1 -
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index c947def..eea0003 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -710,20 +710,20 @@ u8 rtl_mrate_idx_to_arfr_id(
> ret = RATEID_IDX_BGN_40M_1SS;
> else
> ret = RATEID_IDX_BGN_40M_2SS;
> - ; break;
> + break;
> case RATR_INX_WIRELESS_N:
> case RATR_INX_WIRELESS_NG:
> if (rtlphy->rf_type == RF_1T1R)
> ret = RATEID_IDX_GN_N1SS;
> else
> ret = RATEID_IDX_GN_N2SS;
> - ; break;
> + break;
> case RATR_INX_WIRELESS_NB:
> if (rtlphy->rf_type == RF_1T1R)
> ret = RATEID_IDX_BGN_20M_1SS_BN;
> else
> ret = RATEID_IDX_BGN_20M_2SS_BN;
> - ; break;
> + break;
> case RATR_INX_WIRELESS_GB:
> ret = RATEID_IDX_BG;
> break;
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> index 8c08c76..e10a91a 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> +++ b/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
> @@ -142,7 +142,6 @@ void odm_c2h_ra_para_report_handler(void *dm_void, u8 *cmd_buf, u8 cmd_len)
> "SGI_support =", cmd_buf[7]);
> ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE, "%5s %d\n",
> "Rate_ID =", cmd_buf[8]);
> - ;
> }
> ODM_RT_TRACE(dm, ODM_FW_DEBUG_TRACE,
> "-------------------------------\n");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303190913.GA4555%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>