From: Colin Ian King <[email protected]>
Variable sg_off is assigned a value but it is never read, hence it is
redundant and can be removed.
Cleans up clang warning:
net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read
Signed-off-by: Colin Ian King <[email protected]>
---
net/rds/message.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/rds/message.c b/net/rds/message.c
index 90dcdcfe9f62..9c41bdd9e444 100644
--- a/net/rds/message.c
+++ b/net/rds/message.c
@@ -357,7 +357,6 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in
int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
{
- unsigned long sg_off;
struct scatterlist *sg;
int ret = 0;
int length = iov_iter_count(from);
@@ -370,7 +369,6 @@ int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
* now allocate and copy in the data payload.
*/
sg = rm->data.op_sg;
- sg_off = 0; /* Dear gcc, sg->page will be null from kzalloc. */
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
--
2.15.1
On (03/11/18 17:27), Colin King wrote:
> Variable sg_off is assigned a value but it is never read, hence it is
> redundant and can be removed.
>
Acked-by: Sowmini Varadhan <[email protected]>
On 3/11/18 9:27 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Variable sg_off is assigned a value but it is never read, hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> net/rds/message.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks Colin !!
Acked-by: Santosh Shilimkar <[email protected]>
From: Colin King <[email protected]>
Date: Sun, 11 Mar 2018 17:27:56 +0100
> From: Colin Ian King <[email protected]>
>
> Variable sg_off is assigned a value but it is never read, hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read
>
> Signed-off-by: Colin Ian King <[email protected]>
Applied.