Note: This is compile only tested as I have no access to the hw.
This variable was not used anywhere in the code. Removing it saves 24 bytes.
add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24)
Function old new delta
rxe_qp_state_name 24 - -24
Total: Before=3348732, After=3348708, chg -0.00%
Signed-off-by: Hernán Gonzalez <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_qp.c | 9 ---------
drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
2 files changed, 11 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index 137d6c0..ba4652f 100644
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -40,15 +40,6 @@
#include "rxe_queue.h"
#include "rxe_task.h"
-char *rxe_qp_state_name[] = {
- [QP_STATE_RESET] = "RESET",
- [QP_STATE_INIT] = "INIT",
- [QP_STATE_READY] = "READY",
- [QP_STATE_DRAIN] = "DRAIN",
- [QP_STATE_DRAINED] = "DRAINED",
- [QP_STATE_ERROR] = "ERROR",
-};
-
static int rxe_qp_chk_cap(struct rxe_dev *rxe, struct ib_qp_cap *cap,
int has_srq)
{
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 1019f5e..af1470d 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -139,8 +139,6 @@ enum rxe_qp_state {
QP_STATE_ERROR
};
-extern char *rxe_qp_state_name[];
-
struct rxe_req_info {
enum rxe_qp_state state;
int wqe_index;
--
2.7.4
On Tue, 2018-02-27 at 19:07 -0300, Hernán Gonzalez wrote:
> Note: This is compile only tested as I have no access to the hw.
Hello Hernán,
Are you aware that the only hardware that is needed to test this driver is
an Ethernet interface, and that this driver even supports the loopback
interface?
Bart.
On Tue, Feb 27, 2018 at 07:07:58PM -0300, Hernán Gonzalez wrote:
> Note: This is compile only tested as I have no access to the hw.
> This variable was not used anywhere in the code. Removing it saves 24 bytes.
>
> add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24)
> Function old new delta
> rxe_qp_state_name 24 - -24
> Total: Before=3348732, After=3348708, chg -0.00%
>
> Signed-off-by: Hernán Gonzalez <[email protected]>
> drivers/infiniband/sw/rxe/rxe_qp.c | 9 ---------
> drivers/infiniband/sw/rxe/rxe_verbs.h | 2 --
> 2 files changed, 11 deletions(-)
Applied to for-next, thanks
Jason
On Tue, Feb 27, 2018 at 7:17 PM, Bart Van Assche <[email protected]> wrote:
> On Tue, 2018-02-27 at 19:07 -0300, Hernán Gonzalez wrote:
>> Note: This is compile only tested as I have no access to the hw.
>
> Hello Hernán,
>
> Are you aware that the only hardware that is needed to test this driver is
> an Ethernet interface, and that this driver even supports the loopback
> interface?
>
> Bart.
>
Hello Bart,
No, I didn't know, sorry about that. I'll test it as soon as I can.
Thanks for the response.
Cheers,
Hernán
On Wed, Feb 28, 2018 at 07:58:20PM -0300, Hern?n Gonzalez wrote:
> On Tue, Feb 27, 2018 at 7:17 PM, Bart Van Assche <[email protected]> wrote:
> > On Tue, 2018-02-27 at 19:07 -0300, Hern?n Gonzalez wrote:
> >> Note: This is compile only tested as I have no access to the hw.
> >
> > Hello Hern?n,
> >
> > Are you aware that the only hardware that is needed to test this driver is
> > an Ethernet interface, and that this driver even supports the loopback
> > interface?
> >
> > Bart.
> >
>
> Hello Bart,
>
> No, I didn't know, sorry about that. I'll test it as soon as I can.
> Thanks for the response.
Reviewed-by: Yuval Shaia <[email protected]>
Tested-by: Yuval Shaia <[email protected]>
>
> Cheers,
> Hern?n
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html