2018-02-21 22:30:57

by Michael McCormick

Subject: [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock

Bit clear operation was missing ~

Signed-off-by: Michael McCormick <[email protected]>
---
drivers/rtc/rtc-pcf85063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index a06dff9..67bc763 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -70,7 +70,7 @@ static int pcf85063_start_clock(struct i2c_client *client, u8 ctrl1)
s32 ret;

/* start the clock */
- ctrl1 &= PCF85063_REG_CTRL1_STOP;
+ ctrl1 &= ~PCF85063_REG_CTRL1_STOP;

ret = i2c_smbus_write_byte_data(client, PCF85063_REG_CTRL1, ctrl1);
if (ret < 0) {
--
2.7.4

2018-03-13 00:42:37

by Alexandre Belloni

Subject: Re: [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock

On 22/02/2018 at 11:29:24 +1300, Michael McCormick wrote:
> Bit clear operation was missing ~
>
> Signed-off-by: Michael McCormick <[email protected]>
> ---
> drivers/rtc/rtc-pcf85063.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com