2018-03-13 06:22:20

by <Hariprasath Elango>

Subject: [PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

From: HariPrasath Elango <[email protected]>

Kmalloc followed by memcpy can be replaced by kmemdup.

Signed-off-by: HariPrasath Elango <[email protected]>
---
drivers/staging/wilc1000/linux_mon.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index f93f411..c6fd6b3 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -146,7 +146,7 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len)
if (!mgmt_tx)
return -ENOMEM;

- mgmt_tx->buff = kmalloc(len, GFP_ATOMIC);
+ mgmt_tx->buff = kmemdup(buf, len, GFP_ATOMIC);
if (!mgmt_tx->buff) {
kfree(mgmt_tx);
return -ENOMEM;
@@ -154,7 +154,6 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len)

mgmt_tx->size = len;

- memcpy(mgmt_tx->buff, buf, len);
wilc_wlan_txq_add_mgmt_pkt(dev, mgmt_tx, mgmt_tx->buff, mgmt_tx->size,
mgmt_tx_complete);

--
2.10.0.GIT

2018-03-13 07:44:20

by Ajay Singh

Subject: Re: [PATCH] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

On Tue, 13 Mar 2018 11:50:48 +0530
<[email protected]> wrote:

> From: HariPrasath Elango <[email protected]>
>
> Kmalloc followed by memcpy can be replaced by kmemdup.
>
> Signed-off-by: HariPrasath Elango <[email protected]>

Reviewed-by: Ajay Singh <[email protected]>


Regards,
Ajay