2018-03-12 16:08:59

by Craig Tatlor

[permalink] [raw]
Subject: [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string

This was mistakenly pulled from the downstream tree.

Signed-off-by: Craig Tatlor <[email protected]>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
index e87f2c99060d..d85311a0422c 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
@@ -491,7 +491,7 @@
pinctrl-0 = <&i2c8_pins>;

synaptics@2c {
- compatible = "syna,rmi-i2c";
+ compatible = "syna,rmi4-i2c";
reg = <0x2c>;

interrupt-parent = <&msmgpio>;
--
2.16.1



2018-03-12 16:47:28

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: msm8974: castor: Correct typo in touchscreen compatible string

On Mon 12 Mar 09:07 PDT 2018, Craig Tatlor wrote:

> This was mistakenly pulled from the downstream tree.
>
> Signed-off-by: Craig Tatlor <[email protected]>

Thanks Craig,

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> index e87f2c99060d..d85311a0422c 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
> @@ -491,7 +491,7 @@
> pinctrl-0 = <&i2c8_pins>;
>
> synaptics@2c {
> - compatible = "syna,rmi-i2c";
> + compatible = "syna,rmi4-i2c";
> reg = <0x2c>;
>
> interrupt-parent = <&msmgpio>;
> --
> 2.16.1
>

2018-03-13 16:48:48

by Craig Tatlor

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

The compatible string was mistakenly pulled from the downstream tree and the
startup delay property is needed to prevent io errors on initial page select.

Signed-off-by: Craig Tatlor <[email protected]>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
index e87f2c99060d..701b396719c7 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts
@@ -491,7 +491,7 @@
pinctrl-0 = <&i2c8_pins>;

synaptics@2c {
- compatible = "syna,rmi-i2c";
+ compatible = "syna,rmi4-i2c";
reg = <0x2c>;

interrupt-parent = <&msmgpio>;
@@ -506,6 +506,8 @@
pinctrl-names = "default";
pinctrl-0 = <&ts_int_pin>;

+ syna,startup-delay-ms = <10>;
+
rmi-f01@1 {
reg = <0x1>;
syna,nosleep = <1>;
--
2.16.1


2018-03-15 05:23:37

by Andy Gross

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

On Tue, Mar 13, 2018 at 04:46:38PM +0000, Craig Tatlor wrote:
> The compatible string was mistakenly pulled from the downstream tree and the
> startup delay property is needed to prevent io errors on initial page select.
>
> Signed-off-by: Craig Tatlor <[email protected]>

Thanks for the patch. I'll add Bjorn's reviewed-by and apply it.

Regards,
Andy