2018-03-15 06:44:08

by SZ Lin

Subject: [PATCH] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

According to AM335x TRM[1] 14.3.6.2, AM437x TRM[2] 15.3.6.2 and
DRA7 TRM[3] 24.11.4.8.7.3.3, in-band mode in EXT_EN(bit18) register is only
available when PHY is configured in RGMII mode with 10Mbps speed. It will
cause some networking issues without RGMII mode, such as carrier sense
errors and low throughput. TI also mentioned this issue in their forum[4].

This patch adds the check mechanism for PHY interface with RGMII interface
type, the in-band mode can only be set in RGMII mode with 10Mbps speed.

References:
[1]: https://www.ti.com/lit/ug/spruh73p/spruh73p.pdf
[2]: http://www.ti.com/lit/ug/spruhl7h/spruhl7h.pdf
[3]: http://www.ti.com/lit/ug/spruic2b/spruic2b.pdf
[4]: https://e2e.ti.com/support/arm/sitara_arm/f/791/p/640765/2392155

Suggested-by: Holsety Chen (陳憲輝) <[email protected]>
Signed-off-by: SZ Lin (林上智) <[email protected]>
Signed-off-by: Schuyler Patton <[email protected]>
---
drivers/net/ethernet/ti/cpsw.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 1b1b78fdc138..3bbf22ed59cf 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1014,7 +1014,13 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave,
/* set speed_in input in case RMII mode is used in 100Mbps */
if (phy->speed == 100)
mac_control |= BIT(15);
- else if (phy->speed == 10)
+
+ /* in band mode only works in 10Mbps RGMII mode */
+ else if ((phy->speed == 10) &&
+ ((phy->interface == PHY_INTERFACE_MODE_RGMII) ||
+ (phy->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
+ (phy->interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
+ (phy->interface == PHY_INTERFACE_MODE_RGMII_TXID)))
mac_control |= BIT(18); /* In Band mode */

if (priv->rx_pause)
--
2.16.2

2018-03-15 14:33:20

by Andrew Lunn

Subject: Re: [PATCH] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface

> @@ -1014,7 +1014,13 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave,
> /* set speed_in input in case RMII mode is used in 100Mbps */
> if (phy->speed == 100)
> mac_control |= BIT(15);
> - else if (phy->speed == 10)
> +
> + /* in band mode only works in 10Mbps RGMII mode */
> + else if ((phy->speed == 10) &&
> + ((phy->interface == PHY_INTERFACE_MODE_RGMII) ||
> + (phy->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
> + (phy->interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
> + (phy->interface == PHY_INTERFACE_MODE_RGMII_TXID)))

Please use phy_interface_mode_is_rgmii()

Andrew