by jacopo mondi

[permalink] [raw]

Subject: Re: [RFC 2/4] sh: ecovec24: conditionally register backlight device

Hello Dmitry

FYI I am brushing the ecovec board these days as well
https://www.spinics.net/lists/linux-sh/msg52536.html

And I have a board to test with but without any display panel, I'm
afraid.

On Thu, Mar 15, 2018 at 03:42:00PM -0700, Dmitry Torokhov wrote:
> Commit fe79f919f47e ("sh: ecovec24: Use gpio-backlight") removed custom
> backlight support and switched over to generic gpio-backlight driver. The
> comment when we run with DVI states "no backlight", but setting
> gpio_backlight_data.fbdev to NULL actually makes gpio-backlight to react to
> events from any framebuffer device, not ignore them.
>
> We want to get rid of platform data in favor of generic device properties
> in gpio_backlight driver, so we can not have kernel pointers passed around
> to tie the framebuffer device to backlight. Assuming that the intent of the
> above referenced commit was to indeed not export backlight when using DVI,
> let's switch to conditionally registering backlight device so it is not
> present at all in DVI case.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
> arch/sh/boards/mach-ecovec24/setup.c | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 6f929abe0b50f..67633d2d42390 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -368,7 +368,6 @@ static struct platform_device lcdc_device = {
> };
>
> static struct gpio_backlight_platform_data gpio_backlight_data = {
> - .fbdev = &lcdc_device.dev,
> .gpio = GPIO_PTR1,
> .def_value = 1,
> .name = "backlight",
> @@ -987,7 +986,6 @@ static struct platform_device *ecovec_devices[] __initdata = {
> &usb1_common_device,
> &usbhs_device,
> &lcdc_device,
> - &gpio_backlight_device,
> &ceu0_device,
> &ceu1_device,
> &keysc_device,
> @@ -1077,6 +1075,8 @@ static int __init arch_setup(void)
> {
> struct clk *clk;
> bool cn12_enabled = false;
> + bool use_backlight = false;
> + int error;
>
> /* register board specific self-refresh code */
> sh_mobile_register_self_refresh(SUSP_SH_STANDBY | SUSP_SH_SF |
> @@ -1193,9 +1193,6 @@ static int __init arch_setup(void)
> lcdc_info.ch[0].lcd_modes = ecovec_dvi_modes;
> lcdc_info.ch[0].num_modes = ARRAY_SIZE(ecovec_dvi_modes);
>
> - /* No backlight */
> - gpio_backlight_data.fbdev = NULL;
> -
> gpio_set_value(GPIO_PTA2, 1);
> gpio_set_value(GPIO_PTU1, 1);
> } else {
> @@ -1217,6 +1214,8 @@ static int __init arch_setup(void)
> /* enable TouchScreen */
> i2c_register_board_info(0, &ts_i2c_clients, 1);
> irq_set_irq_type(IRQ0, IRQ_TYPE_LEVEL_LOW);
> +
> + use_backlight = true;
> }
>
> /* enable CEU0 */
> @@ -1431,8 +1430,19 @@ static int __init arch_setup(void)
> gpio_set_value(GPIO_PTG4, 1);
> #endif
>
> - return platform_add_devices(ecovec_devices,
> - ARRAY_SIZE(ecovec_devices));
> + error = platform_add_devices(ecovec_devices,
> + ARRAY_SIZE(ecovec_devices));

I would invert this.
Register the backlight first, then all other devices.

> + if (error)
> + return error;
> +
> + if (use_backlight) {
> + error = platform_device_add(&gpio_backlight_device);
> + if (error)
> + pr_warn("%s: failed to register backlight: %d\n",
> + error);

Could you use dev_warn here? Also the format is wrong, I assume you
are missing a '__func__' as second function argument.

Also, you may want to return error.

Thanks
j

> + }
> +
> + return 0;
> }
> arch_initcall(arch_setup);
>
> --
> 2.16.2.804.g6dcf76e118-goog
>

Attachments:

(No filename) (3.65 kB)
signature.asc (836.00 B)
Download all attachments

2018-03-16 10:12:39

On 03/18/2018 02:16 AM, Rich Felker wrote:
>> Umh, but I’m still using the SH7724 Evovec board. Please don’t
>> remove support for that.
>>
>> The SuperH port of the Linux kernel is still maintained.
>
> Thanks. At some point it would be nice to remove the board file, but
> only once the conversion to device tree happens. If anyone has a list
> of boards that people are still using or have access to and who can do
> testing, it would be nice to compile that somewhere so we can figure
> out what needs to be tested and who can test it.

We should maybe create a wiki page somewhere. Either in the kernel wiki
(I don't have an account for that) or the Debian Wiki.

Here's what I still use:

- Renesas SH7724 Evovec
- Renesas SH7786LCR Evaluation Board
- LANDISK SH7751
- Sega Dreamcast (although I currently don't use that)
- NextVoD (currently not in the kernel)

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

2018-03-18 10:56:08

On Thu, Mar 15, 2018 at 11:41 PM, Dmitry Torokhov
<[email protected]> wrote:

> This series attempts to remove platform data support from gpio_blackllist
> driver

We really need a GPIO blacklist driver in the kernel, but for
not let's fix backlight :D :D

> and switch it over to generic device properties/GPIO tables.

This series:
Reviewed-by: Linus Walleij <[email protected]>

> Please note that I do not have the hardware (do we even care about
> ecovec24? I'd like to rip out platform data support from tsc2007 as
> well, but ecovec24 is using custom pendown handler and GPIOs have
> to be switched off from interrupt mode to GPIO and back in that
> pendown handler, which is all quite messy. If we do not care about
> this board I'd much rather removed that custom pendown).

I am also struggling with refactoring of board files, all over the place.
At least Arnd deleted the Blackfin stuff now, but the misc ARM board
and MIPS stuff still give me the creeps sometimes.

I guess if maintainers of the boards are not there to even ACK
patches we can propose patches to simply delete them.

Yours,
Linus Walleij