2018-03-20 08:35:29

by Nikita Yushchenko

Subject: [PATCH] clk: cs2000: set pm_ops in hibernate-compatible way

Use SET_LATE_SYSTEM_SLEEP_PM_OPS() macro instead of direct assignment to
.resume_early field.

This fixes initialization of CS2000 in restore from hibernation in case
of kernel used to load image did not initialize CS2000 while kernel
being restored had CS2000 initialized.

Signed-off-by: Nikita Yushchenko <[email protected]>
---
drivers/clk/clk-cs2000-cp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c
index e8ea81c30f0c..c58019750b7e 100644
--- a/drivers/clk/clk-cs2000-cp.c
+++ b/drivers/clk/clk-cs2000-cp.c
@@ -549,7 +549,7 @@ static int cs2000_resume(struct device *dev)
}

static const struct dev_pm_ops cs2000_pm_ops = {
- .resume_early = cs2000_resume,
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(NULL, cs2000_resume)
};

static struct i2c_driver cs2000_driver = {
--
2.11.0

2018-04-06 18:27:56

by Stephen Boyd

Subject: Re: [PATCH] clk: cs2000: set pm_ops in hibernate-compatible way

Quoting Nikita Yushchenko (2018-03-20 01:33:23)
> Use SET_LATE_SYSTEM_SLEEP_PM_OPS() macro instead of direct assignment to
> .resume_early field.
>
> This fixes initialization of CS2000 in restore from hibernation in case
> of kernel used to load image did not initialize CS2000 while kernel
> being restored had CS2000 initialized.
>
> Signed-off-by: Nikita Yushchenko <[email protected]>
> ---

Applied to clk-next