2018-03-20 11:45:31

by <Hariprasath Elango>

Subject: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

From: HariPrasath Elango <[email protected]>

In this case,there is only a single switch case statement.So replacing
by a simple if condition

Signed-off-by: HariPrasath Elango <[email protected]>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 9d8d5d0..730d64f 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -776,14 +776,8 @@ static int connect(struct wiphy *wiphy, struct net_device *dev,
}

if (sme->crypto.n_akm_suites) {
- switch (sme->crypto.akm_suites[0]) {
- case WLAN_AKM_SUITE_8021X:
+ if (sme->crypto.akm_suites[0] == WLAN_AKM_SUITE_8021X)
auth_type = IEEE8021;
- break;
-
- default:
- break;
- }
}

curr_channel = nw_info->ch;
--
2.10.0.GIT

2018-03-20 11:48:28

by Greg Kroah-Hartman

Subject: Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 05:13:31PM +0530, [email protected] wrote:
> From: HariPrasath Elango <[email protected]>
>
> In this case,there is only a single switch case statement.So replacing
> by a simple if condition
>
> Signed-off-by: HariPrasath Elango <[email protected]>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)

What changed from v1? Always put that information below the --- line,
like the kernel documentation asks you to do.

v3? :)

thanks,

greg k-h

2018-03-20 12:10:47

by <Hariprasath Elango>

Subject: Re: [PATCHv2] staging: wilc1000: replace switch statement by simple if condition

On Tue, Mar 20, 2018 at 12:47:21PM +0100, Greg KH wrote:
> On Tue, Mar 20, 2018 at 05:13:31PM +0530, [email protected] wrote:
> > From: HariPrasath Elango <[email protected]>
> >
> > In this case,there is only a single switch case statement.So replacing
> > by a simple if condition
> >
> > Signed-off-by: HariPrasath Elango <[email protected]>
> > ---
> > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +-------
> > 1 file changed, 1 insertion(+), 7 deletions(-)
>
> What changed from v1? Always put that information below the --- line,
> like the kernel documentation asks you to do.
>
> v3? :)
>
> thanks,
>
> greg k-h

Lesson learned. I will send a v3 with version history included

regards,
hari prasath