2018-03-20 16:45:10

by Valdis Klētnieks

[permalink] [raw]
Subject: linux-next 20180320 compile failure - tools/lib/str_error_r.c

Not sure who to blame here, or what changed in gcc between 0.16 and 0.19,
or what the proper fix is here....

next-20180307 with "gcc version 8.0.1 20180222 (Red Hat 8.0.1-0.16)" built and runs fine.

next-20180320 with "gcc (GCC) 8.0.1 20180317 (Red Hat 8.0.1-0.19)" dies a horrid death early
during the compile:

CC /usr/src/linux-next/tools/objtool/str_error_r.o
../lib/str_error_r.c: In function 'str_error_r':
../lib/str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
^~~~~~~~
cc1: all warnings being treated as errors
mv: cannot stat '/usr/src/linux-next/tools/objtool/.str_error_r.o.tmp': No such file or directory
make[3]: *** [Build:22: /usr/src/linux-next/tools/objtool/str_error_r.o] Error 1
make[2]: *** [Makefile:46: /usr/src/linux-next/tools/objtool/objtool-in.o] Error 2
make[1]: *** [Makefile:63: objtool] Error 2
make: *** [Makefile:1681: tools/objtool] Error 2



Attachments:
(No filename) (497.00 B)

2018-03-21 13:31:14

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: linux-next 20180320 compile failure - tools/lib/str_error_r.c

Em Tue, Mar 20, 2018 at 12:43:32PM -0400, [email protected] escreveu:
> Not sure who to blame here, or what changed in gcc between 0.16 and 0.19,
> or what the proper fix is here....
>
> next-20180307 with "gcc version 8.0.1 20180222 (Red Hat 8.0.1-0.16)" built and runs fine.
>
> next-20180320 with "gcc (GCC) 8.0.1 20180317 (Red Hat 8.0.1-0.19)" dies a horrid death early
> during the compile:
>
> CC /usr/src/linux-next/tools/objtool/str_error_r.o
> ../lib/str_error_r.c: In function 'str_error_r':
> ../lib/str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
> snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
> ^~~~~~~~
> cc1: all warnings being treated as errors
> mv: cannot stat '/usr/src/linux-next/tools/objtool/.str_error_r.o.tmp': No such file or directory
> make[3]: *** [Build:22: /usr/src/linux-next/tools/objtool/str_error_r.o] Error 1
> make[2]: *** [Makefile:46: /usr/src/linux-next/tools/objtool/objtool-in.o] Error 2
> make[1]: *** [Makefile:63: objtool] Error 2
> make: *** [Makefile:1681: tools/objtool] Error 2
>

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=854e55ad289e

- Arnaldo

2018-03-21 18:39:47

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: linux-next 20180320 compile failure - tools/lib/str_error_r.c

On Wed, 21 Mar 2018 10:29:38 -0300, Arnaldo Carvalho de Melo said:
> Em Tue, Mar 20, 2018 at 12:43:32PM -0400, [email protected] escreveu:

> > next-20180320 with "gcc (GCC) 8.0.1 20180317 (Red Hat 8.0.1-0.19)" dies a horrid death early
> > during the compile:
> >
> > CC /usr/src/linux-next/tools/objtool/str_error_r.o
> > ../lib/str_error_r.c: In function 'str_error_r':
> > ../lib/str_error_r.c:25:3: error: passing argument 1 to restrict-qualified parameter aliases with argument 5 [-Werror=restrict]
> > snprintf(buf, buflen, "INTERNAL ERROR: strerror_r(%d, %p, %zd)=%d", errnum, buf, buflen, err);
> > ^~~~~~~~
> > cc1: all warnings being treated as errors
> > mv: cannot stat '/usr/src/linux-next/tools/objtool/.str_error_r.o.tmp': No such file or directory
> > make[3]: *** [Build:22: /usr/src/linux-next/tools/objtool/str_error_r.o] Error 1
> > make[2]: *** [Makefile:46: /usr/src/linux-next/tools/objtool/objtool-in.o] Error 2
> > make[1]: *** [Makefile:63: objtool] Error 2
> > make: *** [Makefile:1681: tools/objtool] Error 2
> >
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=854e55ad289e

Confirming that fixes the problem...


Attachments:
(No filename) (497.00 B)