2018-03-21 04:34:25

by Dan Williams

Subject: [PATCH] libnvdimm, region: hide persistence_domain when unknown

Similar to other region attributes, do not emit the persistence_domain
attribute if its contents are empty.

Fixes: 96c3a239054a ("libnvdimm: expose platform persistence attr...")
Cc: Dave Jiang <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
---
drivers/nvdimm/region_devs.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
index e6d01911e092..a8e9d428c0a5 100644
--- a/drivers/nvdimm/region_devs.c
+++ b/drivers/nvdimm/region_devs.c
@@ -593,6 +593,13 @@ static umode_t region_visible(struct kobject *kobj, struct attribute *a, int n)
return 0;
}

+ if (a == &dev_attr_persistence_domain.attr) {
+ if ((nd_region->flags & (BIT(ND_REGION_PERSIST_CACHE)
+ | BIT(ND_REGION_PERSIST_MEMCTRL))) == 0)
+ return 0;
+ return a->mode;
+ }
+
if (a != &dev_attr_set_cookie.attr
&& a != &dev_attr_available_size.attr)
return a->mode;

2018-03-21 17:12:54

by Ross Zwisler

Subject: Re: [PATCH] libnvdimm, region: hide persistence_domain when unknown

On Tue, Mar 20, 2018 at 09:23:21PM -0700, Dan Williams wrote:
> Similar to other region attributes, do not emit the persistence_domain
> attribute if its contents are empty.
>
> Fixes: 96c3a239054a ("libnvdimm: expose platform persistence attr...")
> Cc: Dave Jiang <[email protected]>
> Signed-off-by: Dan Williams <[email protected]>

Looks good to me.

Reviewed-by: Ross Zwisler <[email protected]>