2018-03-24 10:19:32

by Arushi Singhal

Subject: [PATCH] mtd: nand: do not initialise statics to 0 or NULL

This patch fixes the checkpatch.pl error to ams-delta.c.
ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Arushi Singhal <[email protected]>
---
drivers/mtd/nand/ams-delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
index 6e7f6e0..8e89452 100644
--- a/drivers/mtd/nand/ams-delta.c
+++ b/drivers/mtd/nand/ams-delta.c
@@ -35,7 +35,7 @@
/*
* MTD structure for E3 (Delta)
*/
-static struct mtd_info *ams_delta_mtd = NULL;
+static struct mtd_info *ams_delta_mtd;

/*
* Define partitions for flash devices
--
2.7.4

2018-05-03 09:56:03

by Boris Brezillon

Subject: Re: [PATCH] mtd: nand: do not initialise statics to 0 or NULL

Hi Arushi,

On Sat, 24 Mar 2018 15:47:27 +0530
Arushi Singhal <[email protected]> wrote:

> This patch fixes the checkpatch.pl error to ams-delta.c.
> ERROR: do not initialise statics to 0 or NULL

Can you rebase on top of nand/next [1] and use
"mtd: rawnand: ams-delta: " for the subject prefix?

Thanks,

Boris

[1]http://git.infradead.org/linux-mtd.git/shortlog/refs/heads/nand/next

>
> Signed-off-by: Arushi Singhal <[email protected]>
> ---
> drivers/mtd/nand/ams-delta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
> index 6e7f6e0..8e89452 100644
> --- a/drivers/mtd/nand/ams-delta.c
> +++ b/drivers/mtd/nand/ams-delta.c
> @@ -35,7 +35,7 @@
> /*
> * MTD structure for E3 (Delta)
> */
> -static struct mtd_info *ams_delta_mtd = NULL;
> +static struct mtd_info *ams_delta_mtd;
>
> /*
> * Define partitions for flash devices