2018-03-26 10:08:25

by Sean Wang

Subject: [PATCH net 1/2] net: dsa: mt7530: remove redundant MODULE_ALIAS entries

From: Sean Wang <[email protected]>

MODULE_ALIAS exports information to allow the module to be auto-loaded at
boot for the drivers registered using legacy platform registration.

However, currently the driver is always used by DT-only platform,
MODULE_ALIAS is redundant and should be removed properly.

Signed-off-by: Sean Wang <[email protected]>
---
drivers/net/dsa/mt7530.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 8a0bb00..d31246c 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1424,4 +1424,3 @@ mdio_module_driver(mt7530_mdio_driver);
MODULE_AUTHOR("Sean Wang <[email protected]>");
MODULE_DESCRIPTION("Driver for Mediatek MT7530 Switch");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:mediatek-mt7530");
--
2.7.4

2018-03-26 10:08:47

by Sean Wang

Subject: [PATCH net 2/2] net: dsa: mt7530: fix module autoloading for OF platform drivers

From: Sean Wang <[email protected]>

It's required to create a modules.alias via MODULE_DEVICE_TABLE helper
for the OF platform driver. Otherwise, module autoloading cannot work.

Signed-off-by: Sean Wang <[email protected]>
---
drivers/net/dsa/mt7530.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index d31246c..4e53c5c 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1409,6 +1409,7 @@ static const struct of_device_id mt7530_of_match[] = {
{ .compatible = "mediatek,mt7530" },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, mt7530_of_match);

static struct mdio_driver mt7530_mdio_driver = {
.probe = mt7530_probe,
--
2.7.4

2018-03-26 15:34:34

by Andrew Lunn

Subject: Re: [PATCH net 1/2] net: dsa: mt7530: remove redundant MODULE_ALIAS entries

On Mon, Mar 26, 2018 at 06:07:09PM +0800, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> MODULE_ALIAS exports information to allow the module to be auto-loaded at
> boot for the drivers registered using legacy platform registration.
>
> However, currently the driver is always used by DT-only platform,
> MODULE_ALIAS is redundant and should be removed properly.
>
> Signed-off-by: Sean Wang <[email protected]>

For this, and the second patch:

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2018-03-26 17:11:09

by David Miller

Subject: Re: [PATCH net 1/2] net: dsa: mt7530: remove redundant MODULE_ALIAS entries

From: <[email protected]>
Date: Mon, 26 Mar 2018 18:07:09 +0800

> From: Sean Wang <[email protected]>
>
> MODULE_ALIAS exports information to allow the module to be auto-loaded at
> boot for the drivers registered using legacy platform registration.
>
> However, currently the driver is always used by DT-only platform,
> MODULE_ALIAS is redundant and should be removed properly.
>
> Signed-off-by: Sean Wang <[email protected]>

Applied.

2018-03-26 17:11:14

by David Miller

Subject: Re: [PATCH net 2/2] net: dsa: mt7530: fix module autoloading for OF platform drivers

From: <[email protected]>
Date: Mon, 26 Mar 2018 18:07:10 +0800

> From: Sean Wang <[email protected]>
>
> It's required to create a modules.alias via MODULE_DEVICE_TABLE helper
> for the OF platform driver. Otherwise, module autoloading cannot work.
>
> Signed-off-by: Sean Wang <[email protected]>

Applied.