2018-03-26 08:43:45

by Johannes Thumshirn

[permalink] [raw]
Subject: [PATCH] nvme: unexport nvme_start_keep_alive

nvme_start_keep_alive() isn't used outside core.c so unexport it and
make it static.

Signed-off-by: Johannes Thumshirn <[email protected]>
---
drivers/nvme/host/core.c | 3 +--
drivers/nvme/host/nvme.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 7aeca5db7916..884061c7ebee 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -828,7 +828,7 @@ static void nvme_keep_alive_work(struct work_struct *work)
}
}

-void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
+static void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
{
if (unlikely(ctrl->kato == 0))
return;
@@ -838,7 +838,6 @@ void nvme_start_keep_alive(struct nvme_ctrl *ctrl)
ctrl->ka_cmd.common.opcode = nvme_admin_keep_alive;
schedule_delayed_work(&ctrl->ka_work, ctrl->kato * HZ);
}
-EXPORT_SYMBOL_GPL(nvme_start_keep_alive);

void nvme_stop_keep_alive(struct nvme_ctrl *ctrl)
{
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index d733b14ede9d..7915d6d3fc3f 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -394,7 +394,6 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
unsigned timeout, int qid, int at_head,
blk_mq_req_flags_t flags);
int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count);
-void nvme_start_keep_alive(struct nvme_ctrl *ctrl);
void nvme_stop_keep_alive(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl(struct nvme_ctrl *ctrl);
int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl);
--
2.16.2



2018-03-28 08:09:05

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] nvme: unexport nvme_start_keep_alive

On Mon, Mar 26, 2018 at 10:40:15AM +0200, Johannes Thumshirn wrote:
> nvme_start_keep_alive() isn't used outside core.c so unexport it and
> make it static.
>
> Signed-off-by: Johannes Thumshirn <[email protected]>

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2018-03-28 15:07:27

by Keith Busch

[permalink] [raw]