2018-03-30 10:07:24

by Gregory CLEMENT

[permalink] [raw]
Subject: [PATCH] net: mvneta: fix enable of all initialized RXQs

From: Yelena Krivosheev <[email protected]>

In mvneta_port_up() we enable relevant RX and TX port queues by write
queues bit map to an appropriate register.

q_map must be ZERO in the beginning of this process.

Signed-off-by: Yelena Krivosheev <[email protected]>
Signed-off-by: Gregory CLEMENT <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 25e9a551cc8c..3f6fb635738c 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -1132,6 +1132,7 @@ static void mvneta_port_up(struct mvneta_port *pp)
}
mvreg_write(pp, MVNETA_TXQ_CMD, q_map);

+ q_map = 0;
/* Enable all initialized RXQs. */
for (queue = 0; queue < rxq_number; queue++) {
struct mvneta_rx_queue *rxq = &pp->rxqs[queue];
--
2.16.2



2018-03-30 10:24:02

by Thomas Petazzoni

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: fix enable of all initialized RXQs

Hello,

On Fri, 30 Mar 2018 12:05:31 +0200, Gregory CLEMENT wrote:
> From: Yelena Krivosheev <[email protected]>
>
> In mvneta_port_up() we enable relevant RX and TX port queues by write
> queues bit map to an appropriate register.
>
> q_map must be ZERO in the beginning of this process.
>
> Signed-off-by: Yelena Krivosheev <[email protected]>
> Signed-off-by: Gregory CLEMENT <[email protected]>

Acked-by: Thomas Petazzoni <[email protected]>

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

2018-03-30 18:29:48

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: fix enable of all initialized RXQs

From: Gregory CLEMENT <[email protected]>
Date: Fri, 30 Mar 2018 12:05:31 +0200

> From: Yelena Krivosheev <[email protected]>
>
> In mvneta_port_up() we enable relevant RX and TX port queues by write
> queues bit map to an appropriate register.
>
> q_map must be ZERO in the beginning of this process.
>
> Signed-off-by: Yelena Krivosheev <[email protected]>
> Signed-off-by: Gregory CLEMENT <[email protected]>

Applied, thank you.