2018-04-10 07:02:22

by Yuval Shaia

Subject: [PATCH] linux/kernel.h: Fix minor type in comment

Signed-off-by: Yuval Shaia <[email protected]>
---
include/linux/kernel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index ce51455e2adf..a5b4ba3bdb61 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -651,7 +651,7 @@ do { \
* your code. (Extra memory is used for special buffers that are
* allocated when trace_printk() is used.)
*
- * A little optization trick is done here. If there's only one
+ * A little optimization trick is done here. If there's only one
* argument, there's no need to scan the string for printf formats.
* The trace_puts() will suffice. But how can we take advantage of
* using trace_puts() when trace_printk() has only one argument?
--
2.14.3

2018-04-10 07:14:10

by Ingo Molnar

Subject: Re: [PATCH] linux/kernel.h: Fix minor type in comment

* Yuval Shaia <[email protected]> wrote:

> Signed-off-by: Yuval Shaia <[email protected]>
> ---
> include/linux/kernel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index ce51455e2adf..a5b4ba3bdb61 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -651,7 +651,7 @@ do { \
> * your code. (Extra memory is used for special buffers that are
> * allocated when trace_printk() is used.)
> *
> - * A little optization trick is done here. If there's only one
> + * A little optimization trick is done here. If there's only one
> * argument, there's no need to scan the string for printf formats.
> * The trace_puts() will suffice. But how can we take advantage of
> * using trace_puts() when trace_printk() has only one argument?

Please also fix the typo in the title ;-)

Thanks,

Ingo

2018-04-10 07:19:52

by Yuval Shaia

Subject: Re: [PATCH] linux/kernel.h: Fix minor type in comment

On Tue, Apr 10, 2018 at 09:06:26AM +0200, Ingo Molnar wrote:
>
> * Yuval Shaia <[email protected]> wrote:
>
> > Signed-off-by: Yuval Shaia <[email protected]>
> > ---
> > include/linux/kernel.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> > index ce51455e2adf..a5b4ba3bdb61 100644
> > --- a/include/linux/kernel.h
> > +++ b/include/linux/kernel.h
> > @@ -651,7 +651,7 @@ do { \
> > * your code. (Extra memory is used for special buffers that are
> > * allocated when trace_printk() is used.)
> > *
> > - * A little optization trick is done here. If there's only one
> > + * A little optimization trick is done here. If there's only one
> > * argument, there's no need to scan the string for printf formats.
> > * The trace_puts() will suffice. But how can we take advantage of
> > * using trace_puts() when trace_printk() has only one argument?
>
> Please also fix the typo in the title ;-)

Sorry, fixed that but forgot to amend :)

Will post v2 in few seconds.

>
> Thanks,
>
> Ingo