2018-04-12 16:25:34

by Sandipan Das

Subject: [PATCH] perf tests: Disable breakpoint accounting test for powerpc

We disable this test as instruction breakpoints (HW_BREAKPOINT_X)
are not available for powerpc.

Before applying patch:

21: Breakpoint accounting :
--- start ---
test child forked, pid 3635
failed opening event 0
failed opening event 0
watchpoints count 1, breakpoints count 0, has_ioctl 1, share 0
test child finished with -2
---- end ----
Breakpoint accounting: Skip

After applying patch:

21: Breakpoint accounting : Disabled

Signed-off-by: Sandipan Das <[email protected]>
---
tools/perf/tests/builtin-test.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 625f5a6772af..cac8f8889bc3 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -118,6 +118,7 @@ static struct test generic_tests[] = {
{
.desc = "Breakpoint accounting",
.func = test__bp_accounting,
+ .is_supported = test__bp_signal_is_supported,
},
{
.desc = "Number of exit events of a simple workload",
--
2.14.3

2018-04-12 17:22:22

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf tests: Disable breakpoint accounting test for powerpc

Em Thu, Apr 12, 2018 at 09:51:40PM +0530, Sandipan Das escreveu:
> We disable this test as instruction breakpoints (HW_BREAKPOINT_X)
> are not available for powerpc.

Thanks, applied.

- Arnaldo

2018-04-16 08:08:57

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf tests: Disable breakpoint accounting test for powerpc

Commit-ID: 4b163ca343b45855b03114ef2ab47c454989d55c
Gitweb: https://git.kernel.org/tip/4b163ca343b45855b03114ef2ab47c454989d55c
Author: Sandipan Das <[email protected]>
AuthorDate: Thu, 12 Apr 2018 21:51:40 +0530
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 12 Apr 2018 14:20:21 -0300

perf tests: Disable breakpoint accounting test for powerpc

We disable this test as instruction breakpoints (HW_BREAKPOINT_X) are
not available for powerpc.

Before applying patch:

21: Breakpoint accounting :
--- start ---
test child forked, pid 3635
failed opening event 0
failed opening event 0
watchpoints count 1, breakpoints count 0, has_ioctl 1, share 0
test child finished with -2
---- end ----
Breakpoint accounting: Skip

After applying patch:

21: Breakpoint accounting : Disabled

Signed-off-by: Sandipan Das <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Naveen N. Rao <[email protected]>
Cc: Ravi Bangoria <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/tests/builtin-test.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 625f5a6772af..cac8f8889bc3 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -118,6 +118,7 @@ static struct test generic_tests[] = {
{
.desc = "Breakpoint accounting",
.func = test__bp_accounting,
+ .is_supported = test__bp_signal_is_supported,
},
{
.desc = "Number of exit events of a simple workload",