2018-04-14 10:53:12

by Peng Hao

Subject: [PATCH] selftests:vm: add include file

userfaultfd.c: In function ‘hugetlb_release_pages’:
userfaultfd.c:145:25: error: ‘FALLOC_FL_PUNCH_HOLE’ undeclared
(first use in this function)

Signed-off-by: Peng Hao <[email protected]>
---
tools/testing/selftests/vm/userfaultfd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index de2f9ec..d8fe447 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -68,6 +68,7 @@
#include <linux/userfaultfd.h>
#include <setjmp.h>
#include <stdbool.h>
+#include <linux/falloc.h>

#ifdef __NR_userfaultfd

--
1.8.3.1

2018-04-14 17:33:50

by Mike Rapoport

Subject: Re: [PATCH] selftests:vm: add include file

On Sun, Apr 15, 2018 at 03:08:56AM +0800, Peng Hao wrote:
> userfaultfd.c: In function ‘hugetlb_release_pages’:
> userfaultfd.c:145:25: error: ‘FALLOC_FL_PUNCH_HOLE’ undeclared
> (first use in this function)
>
> Signed-off-by: Peng Hao <[email protected]>
> ---
> tools/testing/selftests/vm/userfaultfd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
> index de2f9ec..d8fe447 100644
> --- a/tools/testing/selftests/vm/userfaultfd.c
> +++ b/tools/testing/selftests/vm/userfaultfd.c
> @@ -68,6 +68,7 @@
> #include <linux/userfaultfd.h>
> #include <setjmp.h>
> #include <stdbool.h>
> +#include <linux/falloc.h>

The FALLOC_FL_PUNCH_HOLE definition should come from #include <fcntl.h>.
What are the versions of your kernel and the libc-development package?

> #ifdef __NR_userfaultfd
>
> --
> 1.8.3.1
>

--
Sincerely yours,
Mike.