2018-04-19 04:06:02

by dann frazier

Subject: [PATCH] net: hns: Avoid action name truncation

When longer interface names are used, the action names exposed in
/proc/interrupts and /proc/irq/* maybe truncated. For example, when
using the predictable name algorithm in systemd on a HiSilicon D05,
I see:

ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
enahisic2i0-tx0
enahisic2i0-tx1
[...]
enahisic2i0-tx8
enahisic2i0-tx9
enahisic2i0-tx1
enahisic2i0-tx1
enahisic2i0-tx1
enahisic2i0-tx1
enahisic2i0-tx1
enahisic2i0-tx1

Increase the max ring name length to allow for an interface name
of IFNAMSIZE. After this change, I now see:

$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
enahisic2i0-tx0
enahisic2i0-tx1
enahisic2i0-tx2
[...]
enahisic2i0-tx8
enahisic2i0-tx9
enahisic2i0-tx10
enahisic2i0-tx11
enahisic2i0-tx12
enahisic2i0-tx13
enahisic2i0-tx14
enahisic2i0-tx15

Signed-off-by: dann frazier <[email protected]>
---
drivers/net/ethernet/hisilicon/hns/hnae.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h b/drivers/net/ethernet/hisilicon/hns/hnae.h
index 3e62692af011..fa5b30f547f6 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.h
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
@@ -87,7 +87,7 @@ do { \

#define HNAE_AE_REGISTER 0x1

-#define RCB_RING_NAME_LEN 16
+#define RCB_RING_NAME_LEN (IFNAMSIZ + 4)

#define HNAE_LOWEST_LATENCY_COAL_PARAM 30
#define HNAE_LOW_LATENCY_COAL_PARAM 80
--
2.17.0

2018-04-19 20:32:32

by David Miller

Subject: Re: [PATCH] net: hns: Avoid action name truncation

From: dann frazier <[email protected]>
Date: Wed, 18 Apr 2018 21:55:41 -0600

> When longer interface names are used, the action names exposed in
> /proc/interrupts and /proc/irq/* maybe truncated. For example, when
> using the predictable name algorithm in systemd on a HiSilicon D05,
> I see:
>
> ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
> enahisic2i0-tx0
> enahisic2i0-tx1
> [...]
> enahisic2i0-tx8
> enahisic2i0-tx9
> enahisic2i0-tx1
> enahisic2i0-tx1
> enahisic2i0-tx1
> enahisic2i0-tx1
> enahisic2i0-tx1
> enahisic2i0-tx1
>
> Increase the max ring name length to allow for an interface name
> of IFNAMSIZE. After this change, I now see:
>
> $ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'
> enahisic2i0-tx0
> enahisic2i0-tx1
> enahisic2i0-tx2
> [...]
> enahisic2i0-tx8
> enahisic2i0-tx9
> enahisic2i0-tx10
> enahisic2i0-tx11
> enahisic2i0-tx12
> enahisic2i0-tx13
> enahisic2i0-tx14
> enahisic2i0-tx15
>
> Signed-off-by: dann frazier <[email protected]>

Applied, thank you.