2018-04-20 10:23:32

by Pascal Roeleven

[permalink] [raw]
Subject: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays

Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.

Change the duplicate clocks to the probably intended ones.

Signed-off-by: Pascal Roeleven <[email protected]>
---
arch/arm/boot/dts/sun4i-a10.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 77e8436b..3a1c6b45 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -76,7 +76,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_HDMI>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
@@ -88,7 +88,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0";
clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_DE_BE0>,
<&ccu CLK_AHB_DE_FE0>, <&ccu CLK_DE_BE0>,
- <&ccu CLK_AHB_DE_FE0>, <&ccu CLK_TCON0_CH0>,
+ <&ccu CLK_DE_FE0>, <&ccu CLK_TCON0_CH0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
};
@@ -99,7 +99,7 @@
allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
clocks = <&ccu CLK_AHB_TVE0>, <&ccu CLK_AHB_LCD0>,
<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
- <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+ <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
<&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_TVE0>,
<&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
status = "disabled";
--
2.14.1



2018-04-23 07:15:53

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays

On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
> Some displays on SUN4i devices wouldn't properly stay on unless
> 'clk_ignore_unused' is used.
>
> Change the duplicate clocks to the probably intended ones.
>
> Signed-off-by: Pascal Roeleven <[email protected]>

What was the difference with the first patch you sent?

Anyway, I've applied it, thanks

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (513.00 B)
signature.asc (849.00 B)
Download all attachments

2018-04-23 11:04:31

by Pascal Roeleven

[permalink] [raw]
Subject: Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays

On 2018-04-23 09:14, Maxime Ripard wrote:
> On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
>> Some displays on SUN4i devices wouldn't properly stay on unless
>> 'clk_ignore_unused' is used.
>>
>> Change the duplicate clocks to the probably intended ones.
>>
>> Signed-off-by: Pascal Roeleven <[email protected]>
>
> What was the difference with the first patch you sent?
>
> Anyway, I've applied it, thanks
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com

I'm sorry there isn't any.
It's the first patch I have ever send so had some git-send-email issues
and
didn't know the correct procedure to resend a patch.

2018-04-23 12:26:21

by Maxime Ripard

[permalink] [raw]
Subject: Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun4i: Fix incorrect clocks for displays

On Mon, Apr 23, 2018 at 01:01:03PM +0200, Pascal Roeleven wrote:
> On 2018-04-23 09:14, Maxime Ripard wrote:
> > On Fri, Apr 20, 2018 at 12:21:12PM +0200, Pascal Roeleven wrote:
> > > Some displays on SUN4i devices wouldn't properly stay on unless
> > > 'clk_ignore_unused' is used.
> > >
> > > Change the duplicate clocks to the probably intended ones.
> > >
> > > Signed-off-by: Pascal Roeleven <[email protected]>
> >
> > What was the difference with the first patch you sent?
> >
> > Anyway, I've applied it, thanks
> >
> > Maxime
> >
> > --
> > Maxime Ripard, Bootlin (formerly Free Electrons)
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
> I'm sorry there isn't any.
> It's the first patch I have ever send so had some git-send-email issues and
> didn't know the correct procedure to resend a patch.

Just set RESEND in the subject prefix (using --subject-prefix="PATCH
RESEND"), and say why you resent it in the patch / cover letter after
the --- and before the diffstat.

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (1.14 kB)
signature.asc (849.00 B)
Download all attachments