2018-04-24 15:20:01

by Luc Van Oostenryck

Subject: [PATCH] drm/ast: fix mode_valid's return type

The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.

Fix this by using 'enum drm_mode_status' in the driver too.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
drivers/gpu/drm/ast/ast_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 831b73392..036dff8a1 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -799,7 +799,7 @@ static int ast_get_modes(struct drm_connector *connector)
return 0;
}

-static int ast_mode_valid(struct drm_connector *connector,
+static enum drm_mode_status ast_mode_valid(struct drm_connector *connector,
struct drm_display_mode *mode)
{
struct ast_private *ast = connector->dev->dev_private;
--
2.17.0

2018-04-25 07:09:01

by Daniel Vetter

Subject: Re: [PATCH] drm/ast: fix mode_valid's return type

On Tue, Apr 24, 2018 at 03:14:40PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <[email protected]>

Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/ast/ast_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 831b73392..036dff8a1 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -799,7 +799,7 @@ static int ast_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> -static int ast_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status ast_mode_valid(struct drm_connector *connector,
> struct drm_display_mode *mode)
> {
> struct ast_private *ast = connector->dev->dev_private;
> --
> 2.17.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch